search

GrapesJS / mjml

Newsletter Builder with MJML components in GrapesJS
http://grapesjs.com/demo-mjml.html
BSD 3-Clause "New" or "Revised" License
629 stars 226 forks source link

Social custom selection not changing social element behavior #196

Closed premhunt closed 4 years ago

premhunt commented 4 years ago

When we change social icon from settings and select custom. It is not changing the default selected type. Step-1: Drag social element Step-2: Check the code image Step-3: Go to settings and change to custom image Step-4: Go back to code mode and check for change, we still see facebook, it should change to custom image

premhunt commented 4 years ago

Seems I have found the reason , please let me know, if it is fine Line number - 34 in file SocialElement.js need to change from { value: '', name: 'Custom' }, to { value: 'custom', name: 'Custom' },

DRoet commented 4 years ago

uhmm yeah usually custom social elements shouldn't have a name property at all, but having name="custom" is probably fine

DRoet commented 4 years ago

released in v0.2.5

premhunt commented 4 years ago

Thanks @DRoet