search

GrapesJS / mjml

Newsletter Builder with MJML components in GrapesJS
http://grapesjs.com/demo-mjml.html
BSD 3-Clause "New" or "Revised" License
638 stars 228 forks source link

StyleManager not pulling the updated parameters after updating #235

Closed rcloss closed 3 years ago

rcloss commented 3 years ago

I'm using the most recent MJML and GrapesJS and have set up a simple test HTML file using the grapesjs mjml as a base (I remove toastr and other things so the only javascript loading is jquery, grapesjs and the mjml/ckeditor plugins.

Here's an example of what's happening

I start with a clean empty canvas, drag in a 1 column block which has an mj-text in it by default, I click on the mj-text, go to the StyleManager and it has a top padding of 10px, I change it to 25px and the change works, but if I click away and come back even though it's still 25px and if I view source I can see that 25px, in the StyleManager itself it displays 10px in the "Top Padding" box

it seems to be working fine in the demo so I don't know what's going on.

EDIT: I switched through the older versions I still had installed, and it looks like it was working in 0.2.4 and not working as of 0.4.1

Here's the code of my tester html if it helps, but it's all pretty boilerplate

`<!doctype html>

GrapesJS Demo - Free Open Source MJML Newsletter Builder
My Company Slogan here Promotion My Awesome Text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin rutrum enim eget magna efficitur, eu semper augue semper. Aliquam erat volutpat. Cras id dui lectus. Vestibulum sed finibus lectus, sit amet suscipit nibh. Proin nec commodo purus. Sed eget nulla elit. Nulla aliquet mollis faucibus. Learn more Find amazing places Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin rutrum enim eget magna efficitur, eu semper augue semper. Aliquam erat volutpat. Cras id dui lectus. Vestibulum sed finibus lectus. Hello There! Facebook Google Twitter

`

rcloss commented 3 years ago

Looks like while downgrading to a working version helps, if you have a template saved that was created with the newer mjml plugin the stylemanager parameters still don't reflect in the sidebar properly for those blocks that were added with the more recent version of the mjml plugin

aakash2610 commented 3 years ago

I am also facing the same issue, and I am using v0.5.5. Is there any workaround (other than downgrading) or timeline for fixing this issue?

DRoet commented 3 years ago

resolved in v0.5.6

aakash2610 commented 3 years ago

@DRoet, I upgraded to v0.5.6 but still facing the same issue.