search

GrapesJS / mjml

Newsletter Builder with MJML components in GrapesJS
http://grapesjs.com/demo-mjml.html
BSD 3-Clause "New" or "Revised" License
628 stars 226 forks source link

fix for padding not shown correctly in style manager #237

Closed dervagabund closed 3 years ago

dervagabund commented 3 years ago

when using padding instead padding-top/left/right/bottom then the style manager is always using the padding instead of the separate property values. rendering was ok but style manager display did not work.

Should fix issue #235

DRoet commented 3 years ago

Could you please revert the package-lock.json changes?

dervagabund commented 3 years ago

should be fixed - sry

DRoet commented 3 years ago

hmm not sure about this change since it is a revert of https://github.com/artf/grapesjs-mjml/pull/197

dervagabund commented 3 years ago

true, but it does fix the the issue with the editor that it does not recognize the changed values. if the padding: 25px 10px is set, this values always overrides the padding-left/top/right/bottom values, although they are internally still correct. somehow the padding itself is shown. maybe related: i've read somewhere (forgot the source) that if a mjml template is used, the padding-top/left/right/bottom should be used instead of the padding. up to you - i'm using the modified version as it's working and not that confusing for the users because it's not resetting.