search

GrapesJS / mjml

Newsletter Builder with MJML components in GrapesJS
http://grapesjs.com/demo-mjml.html
BSD 3-Clause "New" or "Revised" License
628 stars 226 forks source link

mj-image source no longer works on https site #243

Closed IceCrystal0k closed 3 years ago

IceCrystal0k commented 3 years ago

How to reproduce

open demo site: https://grapesjs.com/demo-mjml.html drag an image The image doesn't appear. In browser console the following error appears: Failed to load resource: net::ERR_CERT_DATE_INVALID

If you open the image link in a new tab and replace http with https, the browser shows an error: Your connection is not private

Either update the source in blocks.js, from: 'http://placehold.it/' to 'https://via.placeholder.com/' (the rest of the parameters remain the same) or provide a way to specify the source of the image by parameters.

I think same issue happens also for grapesjs-preset-newsletter

This can be used as an workaround: #188

DRoet commented 3 years ago

Contributions are always welcome

IceCrystal0k commented 3 years ago

Forked it here: image source option