GrapesJS / mjml

Newsletter Builder with MJML components in GrapesJS
http://grapesjs.com/demo-mjml.html
BSD 3-Clause "New" or "Revised" License
624 stars 222 forks source link

Fixing issue with mj-column, background-color #270

Closed GoodPHP closed 2 years ago

GoodPHP commented 2 years ago

Issue with background-color in component mj-column

If add to canvas next code:

<mjml>
  <mj-head>
    <mj-title>test
    </mj-title>
  </mj-head>
  <mj-body background-color="#e5e5e5" width="729px">
    <!-- header -->
    <mj-section padding="36px 0 31px" background-color="#e7eee8">
      <mj-column padding="0 15px" background-color="#350000" width="200px">
        <mj-text padding="0 0 30px" align="center" color="#fff" font-family="Raleway, sans-serif" font-size="24px" line-height="29px">
          29.11.2021 19:00 MESZ
        </mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

and then if try to change background-color="#350000" to mj-column. Nothing was changed.

My fix copy background-color to style="" and it start works.

ekkeguembel commented 2 years ago

@DRoet this PR fixes an issue that came up in a Mautic project where GrapesJS is now the default editor and we expect to see more involvement and contribution going forward. However, I am not familiar with this repo and the ways of doing things here (and I might ask Adrian but maybe starting some direct contact is better : ) Thus: Is there any good practice that helps getting PRs reviewed & merged quickly?

Thx :)

DRoet commented 2 years ago

Honestly I am not that involved with the project anymore, but I am still pretty active on GitHub and try to merge things ASAP.

Maybe you guys can claim a maintainer role from @artf but he can be pretty busy at times.

EDIT: this change is now released as v0.5.7, thanks for the PR!

ekkeguembel commented 2 years ago

Thanks @DRoet for merging and releasing - plus for kindly helping us getting on board! I guess next time I'll touch base with @artf and over time we'll see where this involvement goes :)