GrapesJS / mjml

Newsletter Builder with MJML components in GrapesJS
http://grapesjs.com/demo-mjml.html
BSD 3-Clause "New" or "Revised" License
636 stars 226 forks source link

Unable to add link to text #98

Closed mathieuk closed 4 years ago

mathieuk commented 5 years ago

When using grapesjs-mjml with the built-in RTE (read: not CKEditor) it seems impossible to add a link to text.

Steps to problem:

Expected behaviour:

Actual behaviour:

I'm also unable to update the HREF attribute by selecting an existing link as the RTE editor gets disabled when you switch cursor focus over to the sidebar.

I've determined that this problem does not occur in regular grapesjs without the grapesjs-mjml plugin.

@artf I'm happy to look into this myself but perhaps you have tips about where to look ?

izaa commented 5 years ago

@mathieuk did you solve this?

AliErdin commented 4 years ago

I have the same issue.

larsdecker commented 4 years ago

Yes, i can confirm that it not working correctly. I can see the href under the components settings. But it was not written to the mjml or the final html code.

Bildschirmfoto 2019-10-23 um 10 20 32

When i have time, i will look at the code and try to fix this issue.

simdrouin commented 4 years ago

I was able to fix this with a cloned version locally, it turns out if I comment out the disableEditing function in src/components/Text.js, as well as removing the reference to this function in the extendFnView array at the top of the same file, this solves the Href issue of links inside Text components. So far I haven't seen any unwanted side-effects of this removal.