GrapesJS / preset-webpage

GrapesJS Plugin Webpage Preset
http://grapesjs.com/demo.html
BSD 3-Clause "New" or "Revised" License
335 stars 291 forks source link

Passive event listeners #48

Closed gunslingor closed 1 year ago

gunslingor commented 4 years ago

The console tends to be full of warnings: [Violation] Added non-passive event listener to a scroll-blocking event. Consider marking event handler as 'passive' to make the page more responsive. See (50 of them)

A little research, its related to a new feature, something about dramatically improved scrolling performance by making assumptions on preventDefaults.

https://stackoverflow.com/questions/39152877/consider-marking-event-handler-as-passive-to-make-the-page-more-responsive https://www.chromestatus.com/feature/5745543795965952

I think the fix would be to change all event listeners to have the added property (but may or may not need switch for older browsers, no idea; passive might need to be false I don't know): addEventListener(t, e, { passive: true} ).