GraphBLAS / LAGraph-Working-Group

Public document and planning repository for the LAGraph Working Group
Other
3 stars 2 forks source link

Return codes #4

Open mcmillan03 opened 4 years ago

mcmillan03 commented 4 years ago

Do we use GrB_Info or have LAGr_Info that contains (possibly) a GrB_Info and a much richer set of information.

Is there an LAGr_error() that does analogous tasks to GrB_error() or something completely different.

ScottKolo commented 4 years ago

Given the discussion in #6, if we go with LAGr_Matrix, we should probably go with LAGr_Info.

As you've pointed out, we can include algorithm-specific error messages and other LAGraph-specific functionality. I think this would be particularly useful given that the LAGr_Matrix being discussed is not opaque, and so we may need to notify the user of a lot more possible errors (e.g. "Hey, you told me this matrix was symmetric and it's not!").

tgmattso commented 4 years ago

I agree with you …. LAGr_info rather than GrB_info.

I really hope that LAGraph is successful as a standalone library and that most of our users will not really know (or care) that GraphBLAS is running behind the scenes.

--Tim

From: Scott Kolodziej notifications@github.com Reply-To: GraphBLAS/LAGraph-Working-Group reply@reply.github.com Date: Wednesday, April 8, 2020 at 6:19 AM To: GraphBLAS/LAGraph-Working-Group LAGraph-Working-Group@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [GraphBLAS/LAGraph-Working-Group] Return codes (#4)

Given the discussion in #6https://github.com/GraphBLAS/LAGraph-Working-Group/issues/6, if we go with LAGr_Matrix, we should probably go with LAGr_Info.

As you've pointed out, we can include algorithm-specific error messages and other LAGraph-specific functionality. I think this would be particularly useful given that the LAGr_Matrix being discussed is not opaque, and so we may need to notify the user of a lot more possible errors (e.g. "Hey, you told me this matrix was symmetric and it's not!").

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GraphBLAS/LAGraph-Working-Group/issues/4#issuecomment-610954221, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AATVMEZLZ2IFKZVHIWG6F3TRLR2SRANCNFSM4LZC7HEQ.