search

GraphBLAS / LAGraph

This is a library plus a test harness for collecting algorithms that use the GraphBLAS. For test coverage reports, see https://graphblas.org/LAGraph/ . Documentation: https://lagraph.readthedocs.org
Other
228 stars 61 forks source link

Which SuiteSparse:GraphBLAS major version to target #100

Closed szarnyasg closed 4 years ago

szarnyasg commented 4 years ago

Currently, the repository uses a mix of v3.3.3 (stable) and 4.0.0 beta. The latter is used the GAP BFS tests.

To make sure that CI isn't constantly red, I'm currently dropping the BFS tests before running the tests: https://github.com/GraphBLAS/LAGraph/blob/c6115e9056ce95b7c6df1d6fd241cde21f241d87/.travis.yml#L25

There was also a problem with the Mac OS build for these tests but this might be resolved as a side effect of migrating to 4.0:

Undefined symbols for architecture x86_64:
  "_omp_get_wtime", referenced from:
      _bfs_log_parent in bfs_log_parent.c.o
DrTimothyAldenDavis commented 4 years ago

Sounds fine. A published version of v4 will take me a while to write, so keeping the tests at v3.3.3 is fine.

szarnyasg commented 4 years ago

Okay, great. Version 3.3.3 works fine at the moment (CI finished successfully for new commits).