search

GraphBLAS / LAGraph

This is a library plus a test harness for collecting algorithms that use the GraphBLAS. For test coverage reports, see https://graphblas.org/LAGraph/ . Documentation: https://lagraph.readthedocs.org
Other
225 stars 59 forks source link

Adding LG_check_coarsen into v1.1 #239

Closed VidithM closed 11 months ago

VidithM commented 11 months ago

@DrTimothyAldenDavis

VidithM commented 11 months ago

Sorry about that, I can't test the builds locally on v1.1 since my GraphBLAS doesn't have GrB_get/GrB_set. I have the latest stable version of GraphBLAS. Do I need to build my GraphBLAS from the GrB_get_set_proposal branch? How were you able to test if the build works?

DrTimothyAldenDavis commented 11 months ago

Yes, you would need to compile LAGraph v1.1 against GraphBLAS 9.0.0 (in the GrB_get_set_proposal branch).

The CI for LAGraph will fail because it doesn't compile against v9.0.0, but that can be ignored.

DrTimothyAldenDavis commented 11 months ago

seeing a compiler error here:

[ 96%] Building C object experimental/benchmark/CMakeFiles/coarsen_matching_demo.dir/coarsen_matching_demo.c.o
In file included from /home/faculty/d/davis/getset/LAGraph/experimental/benchmark/../../src/benchmark/LAGraph_demo.h:23,
                 from /home/faculty/d/davis/getset/LAGraph/experimental/benchmark/coarsen_matching_demo.c:1:
/home/faculty/d/davis/getset/LAGraph/experimental/benchmark/coarsen_matching_demo.c: In function ‘main’:
/home/faculty/d/davis/getset/LAGraph/src/utility/LG_internal.h:208:9: error: ‘LG_FREE_ALL’ undeclared (first use in this function)
  208 |         LG_FREE_ALL ;                           \
      |         ^~~~~~~~~~~
/home/faculty/d/davis/getset/LAGraph/experimental/benchmark/coarsen_matching_demo.c:34:5: note: in expansion of macro ‘LG_TRY’
   34 |     LG_TRY (LAGraph_Random_Init (msg)) ;
      |     ^~~~~~
/home/faculty/d/davis/getset/LAGraph/src/utility/LG_internal.h:208:9: note: each undeclared identifier is reported only once for each function it appears in
  208 |         LG_FREE_ALL ;                           \
      |         ^~~~~~~~~~~
/home/faculty/d/davis/getset/LAGraph/experimental/benchmark/coarsen_matching_demo.c:34:5: note: in expansion of macro ‘LG_TRY’
   34 |     LG_TRY (LAGraph_Random_Init (msg)) ;
      |     ^~~~~~
make[3]: *** [experimental/benchmark/CMakeFiles/coarsen_matching_demo.dir/build.make:76: experimental/benchmark/CMakeFiles/coarsen_matching_demo.dir/coarsen_matching_demo.c.o] Error 1