search

GraphBLAS / LAGraph

This is a library plus a test harness for collecting algorithms that use the GraphBLAS. For test coverage reports, see https://graphblas.org/LAGraph/ . Documentation: https://lagraph.readthedocs.org
Other
229 stars 61 forks source link

LAGraph_ktruss should also use an algorithm that is not dependent on SuiteSparse extensions #24

Closed mcmillan03 closed 2 years ago

mcmillan03 commented 5 years ago

I am looking at LAGraph_ktruss.c and it currently requires SuiteSparse extensions AND a specific version. There is an ktruss algorithm that can be implemented using no extensions and should be implemented in the "#else" section on lines 171-174

DrTimothyAldenDavis commented 5 years ago

I haven't written one yet. It's on my TODO list.

On Sat, Aug 24, 2019 at 6:25 PM Doc McMillan notifications@github.com wrote:

I am looking at LAGraph_ktruss.c and it currently requires SuiteSparse extensions AND a specific version. There is an ktruss algorithm that can be implemented using no extensions and should be implemented in the "#else" section on lines 171-174

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOK73ZFKJ4JI3NWCID3QGG7NVA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHGSAIQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AEYIIOOADS6TPBC7L2VBNA3QGG7NVANCNFSM4IPHPIRQ .

mcmillan03 commented 5 years ago

TzeMeng and I wrote C and GBTL versions last year

On Aug 24, 2019, at 4:49 PM, Tim Davis notifications@github.com wrote:

I haven't written one yet. It's on my TODO list.

On Sat, Aug 24, 2019 at 6:25 PM Doc McMillan notifications@github.com wrote:

I am looking at LAGraph_ktruss.c and it currently requires SuiteSparse extensions AND a specific version. There is an ktruss algorithm that can be implemented using no extensions and should be implemented in the "#else" section on lines 171-174

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOK73ZFKJ4JI3NWCID3QGG7NVA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHGSAIQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AEYIIOOADS6TPBC7L2VBNA3QGG7NVANCNFSM4IPHPIRQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

DrTimothyAldenDavis commented 5 years ago

Can you add it to the LAGraph_ktruss.c file? It would be great to have a version that sticks with the pure GraphBLAS API, with no GxB* extensions.

There's also an LAGraph_allktruss.c function, which is a straightforward extension of ktruss.

On Sat, Aug 24, 2019 at 6:50 PM Doc McMillan notifications@github.com wrote:

TzeMeng and I wrote C and GBTL versions last year

On Aug 24, 2019, at 4:49 PM, Tim Davis notifications@github.com wrote:

I haven't written one yet. It's on my TODO list.

On Sat, Aug 24, 2019 at 6:25 PM Doc McMillan notifications@github.com wrote:

I am looking at LAGraph_ktruss.c and it currently requires SuiteSparse extensions AND a specific version. There is an ktruss algorithm that can be implemented using no extensions and should be implemented in the "#else" section on lines 171-174

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOK73ZFKJ4JI3NWCID3QGG7NVA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHGSAIQ , or mute the thread < https://github.com/notifications/unsubscribe-auth/AEYIIOOADS6TPBC7L2VBNA3QGG7NVANCNFSM4IPHPIRQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOJTUX5TPKLZ3IUMD73QGHCNJA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CJONI#issuecomment-524588853, or mute the thread https://github.com/notifications/unsubscribe-auth/AEYIIOJLLG3SKDBA2FU4OE3QGHCNJANCNFSM4IPHPIRQ .

mcmillan03 commented 5 years ago

My biggest blocker - besides time - is getting it to fit within some style and testing framework for LAGraph. I am also sitting on the delta stepping code.

Any suggestions about how best to proceed that gets code in the repo with the smallest effort and meets minimal requirements?

On Aug 24, 2019, at 4:55 PM, Tim Davis notifications@github.com wrote:

Can you add it to the LAGraph_ktruss.c file? It would be great to have a version that sticks with the pure GraphBLAS API, with no GxB* extensions.

There's also an LAGraph_allktruss.c function, which is a straightforward extension of ktruss.

On Sat, Aug 24, 2019 at 6:50 PM Doc McMillan notifications@github.com wrote:

TzeMeng and I wrote C and GBTL versions last year

On Aug 24, 2019, at 4:49 PM, Tim Davis notifications@github.com wrote:

I haven't written one yet. It's on my TODO list.

On Sat, Aug 24, 2019 at 6:25 PM Doc McMillan notifications@github.com wrote:

I am looking at LAGraph_ktruss.c and it currently requires SuiteSparse extensions AND a specific version. There is an ktruss algorithm that can be implemented using no extensions and should be implemented in the "#else" section on lines 171-174

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOK73ZFKJ4JI3NWCID3QGG7NVA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHGSAIQ , or mute the thread < https://github.com/notifications/unsubscribe-auth/AEYIIOOADS6TPBC7L2VBNA3QGG7NVANCNFSM4IPHPIRQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOJTUX5TPKLZ3IUMD73QGHCNJA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CJONI#issuecomment-524588853, or mute the thread https://github.com/notifications/unsubscribe-auth/AEYIIOJLLG3SKDBA2FU4OE3QGHCNJANCNFSM4IPHPIRQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

DrTimothyAldenDavis commented 5 years ago

The testing framework for ktruss is already there, so that shouldn't be a problem. I could also test it myself if you add the code the LAGraph_ktruss.c; I would just temporarily disable the SuiteSparse-specific part of the code.

On Sun, Aug 25, 2019 at 12:43 PM Doc McMillan notifications@github.com wrote:

My biggest blocker - besides time - is getting it to fit within some style and testing framework for LAGraph. I am also sitting on the delta stepping code.

Any suggestions about how best to proceed that gets code in the repo with the smallest effort and meets minimal requirements?

On Aug 24, 2019, at 4:55 PM, Tim Davis notifications@github.com wrote:

Can you add it to the LAGraph_ktruss.c file? It would be great to have a version that sticks with the pure GraphBLAS API, with no GxB* extensions.

There's also an LAGraph_allktruss.c function, which is a straightforward extension of ktruss.

On Sat, Aug 24, 2019 at 6:50 PM Doc McMillan notifications@github.com wrote:

TzeMeng and I wrote C and GBTL versions last year

On Aug 24, 2019, at 4:49 PM, Tim Davis notifications@github.com wrote:

I haven't written one yet. It's on my TODO list.

On Sat, Aug 24, 2019 at 6:25 PM Doc McMillan < notifications@github.com> wrote:

I am looking at LAGraph_ktruss.c and it currently requires SuiteSparse extensions AND a specific version. There is an ktruss algorithm that can be implemented using no extensions and should be implemented in the "#else" section on lines 171-174

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <

https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOK73ZFKJ4JI3NWCID3QGG7NVA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHGSAIQ

,

or mute the thread <

https://github.com/notifications/unsubscribe-auth/AEYIIOOADS6TPBC7L2VBNA3QGG7NVANCNFSM4IPHPIRQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOJTUX5TPKLZ3IUMD73QGHCNJA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CJONI#issuecomment-524588853 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AEYIIOJLLG3SKDBA2FU4OE3QGHCNJANCNFSM4IPHPIRQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/LAGraph/issues/24?email_source=notifications&email_token=AEYIIOI5W4HD734NTQJG2J3QGLADLA5CNFSM4IPHPIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CYF2Q#issuecomment-524649194, or mute the thread https://github.com/notifications/unsubscribe-auth/AEYIIONBH7ZI4W2YH3EMAULQGLADLANCNFSM4IPHPIRQ .

DrTimothyAldenDavis commented 2 years ago

Still not done, but now the v2.0 C API has GrB_select, so this will be simple to do.

DrTimothyAldenDavis commented 2 years ago

Done. It's all GrB now, as is the All-K-truss method.