Closed michelp closed 4 years ago
@szarnyasg @DrTimothyAldenDavis moving the GBCOMPACT discussion to here.
Got the linux build under 4 minutes on Travis using the compact option:
https://travis-ci.org/michelp/LAGraph/builds/657592964
osx is failing, but i've marked it as optional, and it fails fast. it throws a lot of unrecognized warning group warnings.
You can now pass CMAKE_OPTIONS="-DGBCOMPACT=1" to cmake, via the top-level makefile, as (for example):
JOBS=8 CMAKE_OPTIONS="-DGBCOMPACT=1" make
Is that backported to 3.2.0?
I copied this branch to my fork and merged it with master
-- the .travis.yml
file had some conflict, I resolved those and worked on refining the CI configuration: https://github.com/szarnyasg/LAGraph/tree/feature/travis-ci-linux-osx
The OS X build now starts and fails at a later stage. Looking into it.
Okay, the OS X build almost works now. Problems that remain:
wget
-ting it instead of opening it in the browser).Complex directory
fail. Dropping it makes both the OS X
and Linux
builds green! https://travis-ci.org/szarnyasg/LAGraph/builds/657805119It doesn't like this, in complextest.c:
Maybe try
instead. I've seen that before, I think.
On Tue, Mar 3, 2020 at 9:36 AM Gabor Szarnyas notifications@github.com wrote:
Okay, the OS X build almost works now. Problems that remain:
- The log is massive due to a large number of warnings.
- Tests in the Complex directory fail.
Raw log: https://api.travis-ci.org/v3/job/657795742/log.txt (I'd recommend wgetting it instead of opening it in the browser).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/LAGraph/pull/73?email_source=notifications&email_token=AEYIIOOC5QXQUHTLKW7JQ73RFUPYHA5CNFSM4LABYJV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENT63LI#issuecomment-594013613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYIIONYVRQ74427SJUTJSTRFUPYHANCNFSM4LABYJVQ .
I pushed this change but, unfortunately, it did not fix the problem. Raw log: https://api.travis-ci.com/v3/job/293475824/log.txt
@michelp Fantastic, the build is green for both OSs and tests run just fine.
One idea for improving the CI scripts: it's possible to get rid of ldconfig
by using cmake
which, when building LAGraph
, produces a Makefile that looks for GraphBLAS in ../GraphBLAS/Include
.
See my .travis.yml
: https://github.com/szarnyasg/LAGraph/blob/feature/travis-ci-linux-osx/.travis.yml
I'm tweaking mine a bit more, results should come in 10 minutes from now. N.b. you don't actually need make install
as it will discover the files in the ../GraphBLAS/Includes
directory.
I've created a .travis.yml file that should work but now Travis does not start a build... https://github.com/szarnyasg/LAGraph/blob/feature/travis-ci-linux-osx2/.travis.yml
The tests weren't finding GraphBLAS.h, which I was hoping make install would fix.
Travis should provide an evolutionary algorithm that just twiddles all these knobs till it works :)
the build is green for both OSs and tests run just fine.
Correction: it seems that the Mac was (and is) broken due to errors around complex.
I've added a -w
flag to the CMAKE_C_FLAG
. This does not solve the problem but significantly shortens the output log so that it does not freeze the browser for several seconds.
https://travis-ci.org/szarnyasg/LAGraph/jobs/657899922
You can now pass CMAKE_OPTIONS="-DGBCOMPACT=1" to cmake, via the top-level makefile, as (for example):
JOBS=8 CMAKE_OPTIONS="-DGBCOMPACT=1" make