Shape of a vector is ambiguous

GraphBLAS / binsparse-specification

A cross-platform binary storage format for sparse data, particularly sparse matrices.

https://graphblas.org/binsparse-specification/

BSD 3-Clause "New" or "Revised" License

15 stars 4 forks source link

Shape of a vector is ambiguous #41

Open BenBrock opened 9 months ago

BenBrock commented 9 months ago

From reading the spec, it seems that it's ambiguous what we should put under the key shape when the format is DVEC. Do we want shape: 100? shape: [100]? Or shape: [100, 1]?

In order to work well with tensors, I'm guessing we want shape: [100], but we need to make sure it's unambiguous in the spec, and preferably add some examples.

BenBrock commented 9 months ago

@willow-ahrens @eriknw and @ivirshup, do you have opinions here? If we have consensus, I'll go update the spec.

eriknw commented 9 months ago

My opinion: clarify that vectors (including DVEC) are shape e.g. [100] (not 100).

willow-ahrens commented 9 months ago

Yes! This allows scalars to be shape []