search

GraphBLAS / graphblas-api-c

Other
7 stars 3 forks source link

incorrect description of GrB_COMP_STRUCTURE in list of changes in appendices.tex #80

Closed DrTimothyAldenDavis closed 6 months ago

DrTimothyAldenDavis commented 7 months ago

https://github.com/GraphBLAS/graphblas-api-c/blob/6692c3f7f85e73d12bcd70505571bbb4aa46b482/graph-api-c/appendices.tex#L20

GrB_COMP_STRUCTURE is not a descriptor. It is a new value in the GrB_Desc_Value enum type.

tgmattso commented 7 months ago

OK. Thank you for catching this. Help me get the wording right.

This is what it currently says:

         \item We added a new built-in descriptor  {\sf GrB\_COMP\_STRUCTURE} and 
         an explicit reference to the default value of a descriptor field, {\sf GrB\_DEFAULT}.

How about this …

We added new field values of type GrB\_Desc\_Value to use when working 
    with Descriptors, {\sf GrB\_COMP\_STRUCTURE}  and {\sf GrB\_DEFAULT}.

—Tim

On Dec 24, 2023, at 12:23 PM, Tim Davis @.***> wrote:

https://github.com/GraphBLAS/graphblas-api-c/blob/6692c3f7f85e73d12bcd70505571bbb4aa46b482/graph-api-c/appendices.tex#L20

GrB_COMP_STRUCTURE is not a descriptor. It is a new value in the GrB_Desc_Value enum type.

— Reply to this email directly, view it on GitHub https://github.com/GraphBLAS/graphblas-api-c/issues/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATVME7PFVAA2XH3M3RJEYLYLCFLJAVCNFSM6AAAAABBBX3UWOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKMRQGU2DCNY. You are receiving this because you are subscribed to this thread.

DrTimothyAldenDavis commented 6 months ago

That revision looks great to me.