search

GraphQLGuide / apollo-datasource-mongodb

Apollo data source for MongoDB
MIT License
285 stars 64 forks source link

Apollo Server 4 Upgrade #123

Closed nnoce14 closed 1 year ago

nnoce14 commented 1 year ago

Made changes to MongoDataSource to be compliant with how data sources were changed in Apollo Server 4. See latest comment on Issue #114 for more information.

lorensr commented 1 year ago

@nnoce14 thanks so much for submitting! and @devileye98 for reviewing 🙏

Do we need any more automated tests to make sure this works with AS v4?

Could you also add a note to the readme saying which versions of this package support which AS versions, and a link to the old (current) version of the README/docs?

devileye98 commented 1 year ago

ed tests to make sure this w

I forked out this PR and tested it against our application. Apart from a few minor changes in our types, we were able to get the server up and running and were also able to run our E2E and unit tests

nnoce14 commented 1 year ago

I see that both mongodb and mongoose are on older versions. If we could update it to the newest packages, it would be awesome as we can make use of the newer types from both these packages and get rid of any type errors for users consuming this package.

I just updated mongoose from v5 to v7, which is latest. I also updated mongodb from v3 to v4. However, the latest version is v5 but I was unable to get that to work because of an ongoing issue with BSON v5 found here

devileye98 commented 1 year ago

I see that both mongodb and mongoose are on older versions. If we could update it to the newest packages, it would be awesome as we can make use of the newer types from both these packages and get rid of any type errors for users consuming this package.

I just updated mongoose from v5 to v7, which is latest. I also updated mongodb from v3 to v4. However, the latest version is v5 but I was unable to get that to work because of an ongoing issue with BSON v5 found here

I think we resolved this by updating the Bson package. I think that should resolve the issue.

nnoce14 commented 1 year ago

I see that both mongodb and mongoose are on older versions. If we could update it to the newest packages, it would be awesome as we can make use of the newer types from both these packages and get rid of any type errors for users consuming this package.

I just updated mongoose from v5 to v7, which is latest. I also updated mongodb from v3 to v4. However, the latest version is v5 but I was unable to get that to work because of an ongoing issue with BSON v5 found here

I think we resolved this by updating the Bson package. I think that should resolve the issue.

Yeah that seemed to work, thank you. I updated bson as well the other day, but it was still throwing me the same error at the time. All good now, mongodb is latest version.

devileye98 commented 1 year ago

@lorensr , can we get this PR merged since I think all the comments are addressed?

NickDuBois commented 1 year ago

Any hope of this getting merged?

lorensr commented 1 year ago

Sorry folks, very low on time these days! Lmk if anyone's interested in helping out with maintenance. Thanks for the ping Nick.

0.6.0 is now released with this PR. Please comment with how it works for you!

https://github.com/GraphQLGuide/apollo-datasource-mongodb/releases/tag/0.6.0

https://www.npmjs.com/package/apollo-datasource-mongodb?activeTab=versions