search

GraphQLSwift / GraphQL

The Swift GraphQL implementation for macOS and Linux
MIT License
938 stars 72 forks source link

Incremented Runtime Version For Swift 5.0 Compatibility #47

Closed tjarksaul closed 5 years ago

noahemmet commented 5 years ago

In Package.swift, should // swift-tools-version:4.0 be updated to // swift-tools-version:5.0?

noahemmet commented 5 years ago

I also noticed a number of tests weren't passing (locally, at least), but I wasn't able to check if they had passed pre-Swift 5.

tjarksaul commented 5 years ago

In Package.swift, should // swift-tools-version:4.0 be updated to // swift-tools-version:5.0?

It is possible but not neccessary. 4.0 allows it to be built with Swift 4, too.

noahemmet commented 5 years ago

Ah. I wasn't sure if the new Runtime changes were backwards compatible with Swift 4.