Replace Runtime package with Mirror

GraphQLSwift / GraphQL

The Swift GraphQL implementation for macOS and Linux

MIT License

938 stars 72 forks source link

Replace Runtime package with Mirror #82

Closed adam-fowler closed 3 years ago

adam-fowler commented 3 years ago

The Runtime library has loads of errors when you run it with the address sanitizer and crashes the thread sanitizer on Linux. Given the GraphQL package is most likely going to be used in a multi-threaded environment not having the thread sanitizer is a real concern.

It appears all the requirements from Runtime can be satisfied with Mirror so I replaced it. I might have missed something but all the tests pass.

paulofaria commented 3 years ago

Thank you @adam-fowler!

adam-fowler commented 3 years ago

Shall I merge this and the flatten PR?

paulofaria commented 3 years ago

@adam-fowler Please do! Feel free to also create the tags. 😄