GraphQLSwift / Graphiti

The Swift GraphQL Schema framework for macOS and Linux
MIT License
531 stars 67 forks source link

Connections - Adds tests and documentation #108

Closed NeedleInAJayStack closed 1 year ago

NeedleInAJayStack commented 1 year ago

This adds tests and documentation to the Connection system, which should improve stability, maintainability, and adoption of this feature.

cshadek commented 1 year ago

Should there be a test for when a connection is a field on a Type, or is that not needed?

NeedleInAJayStack commented 1 year ago

@cshadek Yeah, I originally had them as object fields, but it made these tests pretty verbose. I've added one here https://github.com/GraphQLSwift/Graphiti/pull/109 where I fix the Connection aliasing issue you reported.