search

GraphQLSwift / Graphiti

The Swift GraphQL Schema framework for macOS and Linux
MIT License
531 stars 67 forks source link

Preserve result order #64

Closed NeedleInAJayStack closed 3 years ago

NeedleInAJayStack commented 3 years ago

PR to align Graphiti with this GraphQL PR: https://github.com/GraphQLSwift/GraphQL/issues/60

@adam-fowler Heads up - I reverted the swift-tools-version because this issue is still present in XCode 12.4. This means that anyone with XCode < 12.5 cannot build Graphiti, even if they are using a Swift 5.4 toolchain.

NeedleInAJayStack commented 3 years ago

This will fail until we update GraphQL dependencies

adam-fowler commented 3 years ago

@NeedleInAJayStack this doesn't make sense you are saying you can build this package with swift 5.2 even though you can't.

NeedleInAJayStack commented 3 years ago

@adam-fowler Yes, I know. I'm trying to find the path of least resistance on working around the XCode bug (I have coworkers who don't often update XCode, they just update their toolchain). If you disagree with changing this here, I understand and will change it back to 5.4.

NeedleInAJayStack commented 3 years ago

@adam-fowler I've changed the swift-tools-version back to 5.4. Thanks for the discussion!