search

Graphcool / graphcool-framework

Apache License 2.0
1.77k stars 131 forks source link

`graphcool local up` upgrades docker images without asking #377

Open marktani opened 6 years ago

marktani commented 6 years ago

Issue by kbrandwijk Tuesday Nov 07, 2017 at 15:43 GMT Originally opened as https://github.com/graphcool/prisma/issues/1195

Current behavior graphcool local pull is the command to get the lastest version of the docker images. However, running graphcool local up also updates the docker images, without asking.

Expected behavior? graphcool local up should only use the images that are already installed.

marktani commented 6 years ago

Comment by kbrandwijk Tuesday Nov 07, 2017 at 16:48 GMT

There is another dimension to this issue. If you install a new version of graphcool, and you already did graphcool local up, the CLI doesn't have a mechanism in place to detect it. If a new version of graphcool contains changes that are incompatible with the running containers, this will break stuff.

I would recommend graphcool deploy to check the version of the running containers, and warn if they are outdated, so you can run graphcool local up again.