search

Graphcool / graphcool-framework

Apache License 2.0
1.77k stars 131 forks source link

Facebook Authentication Tutorial Should Specify react-apollo version number #543

Open localjo opened 6 years ago

localjo commented 6 years ago

Current behavior

The tutorial doesn't work when installing the latest version of react-apollo.

Reproduction

Try to work through the tutorial as-is, you'll get stuck on step 18 when you try to run the app.

Expected behavior?

The app should start without errors.

Either the tutorial should be updated to specify installing react-apollo@1.4.15 or the tutorial should be updated to work with react-apollo@2.

localjo commented 6 years ago

I opened this issue instead of a PR because I wanted to ask the maintainers; would you prefer to update the tutorial to specify react-apollo@1.4.15 or to work with react-apollo@2?

localjo commented 6 years ago

@dpetrick Would you accept PRs that update the Facebook Authentication tutorial and the guide-starters project to work smoothly with all of the latest updates to dependencies and APIs? I've run into a lot of blockers while working through the tutorial, and I'd be happy to contribute the relevant updates that I've figured out.