search

Graphegon / pygraphblas

GraphBLAS for Python
https://graphegon.github.io/pygraphblas/pygraphblas/index.html
Apache License 2.0
343 stars 27 forks source link

Matrix.from_lists() should accept empty lists #22

Closed marci543 closed 4 years ago

marci543 commented 4 years ago

Matrix.from_lists() should accept empty lists to create empty matrix. In that case nrows and ncols are mandatory. Currently it is checked by an assertion here: https://github.com/michelp/pygraphblas/blob/2c34cd49ce1067bbe49b0018168b7c39608ef685/pygraphblas/matrix.py#L77

michelp commented 4 years ago

Thanks @marci543 I'll remove the assert, the type argument will in addition to nrows and ncols be mandatory.

michelp commented 4 years ago

fixed