Type-related patches - Githubissues

Graphegon / pygraphblas

GraphBLAS for Python

https://graphegon.github.io/pygraphblas/pygraphblas/index.html

Apache License 2.0

343 stars 27 forks source link

Type-related patches #45

Closed marci543 closed 4 years ago

marci543 commented 4 years ago

This PR adds the following:

Enable using raw and type-independent operators in Matrix/Vector.apply(), add tests
Determine type parameter in Matrix/Vector constructor when absent

marci543 commented 4 years ago

I would like to ask what the difference is between Vector.gb_type and Vector.type.gb_type. It seems to me that both return the same, but the former does an extra GxB_Vector_type() call. Is this always the case? Can Vector.gb_type be rewritten to use Vector.type.gb_type without the extra function call?

michelp commented 4 years ago

Nice catch, I think object.gb_type can be removed like you suggest. I'll merge this and look into it.