search

Graphegon / pygraphblas

GraphBLAS for Python
https://graphegon.github.io/pygraphblas/pygraphblas/index.html
Apache License 2.0
343 stars 27 forks source link

Fix use of CMake flags in Dockerfile-notebook and in Ubuntu install script #58

Closed szarnyasg closed 4 years ago

szarnyasg commented 4 years ago

I had suspiciously quick (<2 minutes) GrB builds on my laptop even when the COMPACT flag was turned off. This is not a problem in day-to-day prototyping but becomes an issue when one tries to benchmark the performance of pygrb-based implementations.

The cause of the problem is that

make CFLAGS="-DGB_BURBLE=${SS_BURBLE} -DGBCOMPACT=${SS_COMPACT}"

does not pass the arguments correctly. Instead, one needs to use:

cmake .. -DGB_BURBLE=${SS_BURBLE} -DGBCOMPACT=${SS_COMPACT} && make

I did this change in the Ubuntu install script and Dockerfile-notebook, and also bumped GrB to v3.2.2 (as v3.2.0 does not have the GBCOMPACT flag).

Please review @michelp @marci543