search

Graphegon / pygraphblas

GraphBLAS for Python
https://graphegon.github.io/pygraphblas/pygraphblas/index.html
Apache License 2.0
343 stars 27 forks source link

Not all dependencies are installed during install-ubuntu.sh #64

Closed gsvgit closed 4 years ago

gsvgit commented 4 years ago

Some python packages are not installed during installation script execution. For example, contextvars package, required in binaryop.py. This package is not part of the default python installation, so if I want to install pygraphblas from scratch, I should install this package manually. Should it be added to notebook-requirements.txt?

michelp commented 4 years ago

Hi @gsvgit,

contextvars is standard as of Python >= 3.7 which is why pygraphblas requires at least 3.7, are you trying to work with an earlier version? If installing the backported contextvars works for you and all the tests pass, I'd be happy to merge a PR that adds it.

gsvgit commented 4 years ago

Hi,

Thank you, you are right, I should have read the requirements carefully. For Python version 3.7 and higher all works fine. Unfortunately, my Python 3.6 environment is unstable, so, I guess, that right solution is just to follow to requirements)