claim letter - Githubissues

GraphemeNFT / rarible-scaffold

MIT License

0 stars 0 forks source link

Closed dcsan closed 3 years ago

dcsan commented 3 years ago

ok basics working for this but i just return dummy data odd/even for isClaimed

when doing the claimToken method i think we might need:

what about:

sender? (or is this just msg.sender) - ie a way that people other than the person who minted can claim it.
name? if we let people "name" their letters. this is in the UI now, but I'm not sure it adds much? @tomosaigon

on 'claiming' we should mint to: and take money from the user right?? that's the main point of NFTs lol

dcsan commented 3 years ago

@keepRunning now I'm just waiting for

claimToken
getInfo (including all token info like claimed status, maybe owner in case we have a gallery page with everyone's tokens?)

tomosaigon commented 3 years ago

"claim" function will set tokenURI to the passed in uri (an ipfs cid)

tomosaigon commented 3 years ago

"name" is a field in the metadata standard and is presumably used by NFT marketplaces

dcsan commented 3 years ago

yeah those params are there now in the fn but was wondering if we need others...

tomosaigon commented 3 years ago

Name is nice to have, others might also be nice (e.g. a better description) but nothing seems to be a deal breaker for the rest of the hackathon.