search

GraphemeNFT / rarible-scaffold

MIT License
0 stars 0 forks source link

fix hardwired contracts in source #6

Closed dcsan closed 3 years ago

dcsan commented 3 years ago

even for local dev, it seems the contracts are referred to in multiple places in the source AND they will be different for each dev.

at a minimum we need to ignore those files ideally move all these config vars to a single place.

also, its a pain to have to manually edit places in source each time contract is deployed

maybe this works better when we have a shared remote blockchain and contract? but even then not sure how it would work with ssh keys etc to update.

dcsan commented 3 years ago

nb c50b7556a195eafea76e62307847735244e5ddc6

tomosaigon commented 3 years ago

this sucks but we only have to deal with it for another day or so

dcsan commented 3 years ago

i have a make update cmd that also calls publish so the manual editing of files isn't needed. however some of those files aren't ignored so after each pull other devs need to compile and update for local dev.