search

GrapheneOS-Archive / legacy_bugtracker

See the new issue tracker for GrapheneOS at https://github.com/GrapheneOS/os_issue_tracker.
112 stars 11 forks source link

CarrierConfig vendor.xml for Pixel 2 (XL) #826

Closed thestinger closed 5 years ago

thestinger commented 6 years ago

It seems they might have stopped using this and moved to the protobuf files, without code in AOSP to handle them.

xbtc-im commented 6 years ago

What's this with the CarrierConfig anyway ? Wasn't the SIM card supposed to handle all that ?

thestinger commented 6 years ago

Well, it doesn't, there's a massive database of default APNs and the right one is picked based on ids from the SIM card. If there isn't an entry, you need to manually enter an APN for working SMS/MMS and data. This CarrierConfig stuff is needed for some things outside the scope of APN configuration.

xbtc-im commented 6 years ago

Yes, but besides the APN-s there are other issues ? For me there is no issue manually editing the APN settings for the internet, those can easily be looked up anyway ... And does anyone still use MMS ? :)

thestinger commented 6 years ago

Yes, there are other issues, but it mostly works fine with just the standard APN database otherwise we wouldn't have launched Pixel 2 (XL) support. We only do this on the Pixel and Pixel XL, never did it on the Nexus 5X and 6P.

thestinger commented 6 years ago

https://github.com/CopperheadOS/device_google_marlin/blob/oreo-m2-release/overlay/packages/apps/CarrierConfig/res/xml/vendor.xml

xbtc-im commented 6 years ago

As an edit for my previous post: As i see it, MMS is an useless feature, that only adds unnecessary attack surface to the *G standards... It should totally be removed. So without the CarrierConfig, the phone will not be useless, you just need to do a bit of work when you swap sim cards ?

thestinger commented 6 years ago

No, that's not what I said at all.

thestinger commented 6 years ago

Well, it doesn't, there's a massive database of default APNs and the right one is picked based on ids from the SIM card. If there isn't an entry, you need to manually enter an APN for working SMS/MMS and data. This CarrierConfig stuff is needed for some things outside the scope of APN configuration.

thestinger commented 6 years ago

outside the scope of APN configuration.

i.e. nothing to do with basic mobile data and MMS

xbtc-im commented 6 years ago

Yes, sorry about that. There are a lot of other settings too ... Missed that.

thestinger commented 6 years ago

Look at what's in the one we ship for the Pixel / Pixel XL.

xbtc-im commented 6 years ago

Off topic, i wonder what the software in the radio partition is capable of ... AFAIK that's a RTOS handling all the network/radio stuff, i wonder how much access does it have to the main memory / cpu.

thestinger commented 6 years ago

Components like the cellular radio, GPU, media decode/encode engine, etc. are contained by IOMMUs.

thestinger commented 6 years ago

PCIe peripherals may or may not be contained well. You would need to do research more specific to devices. Most of these kinds of components are part of the SoC and the IOMMU configuration is reused across all the devices using the SoC unless they do something very strange.

There's a higher chance of a component separate from the SoC not being properly isolated. A component being on the SoC or having access to memory doesn't mean it isn't contained and likewise a component not being on the SoC doesn't mean it is contained.

xbtc-im commented 6 years ago

Thanks for the clarification