GrapheneOS / AppStore

MIT License
268 stars 29 forks source link

Consider Adding Google Camera #346

Closed MichaelDevon closed 7 months ago

MichaelDevon commented 7 months ago

Some reasons why it could be in your repo:

Many people use it who dont have google services to install from play store.

These people wont get updates.

These people will obtain a wrong version of the app through Aurora or Apkmirror which wont have device specific configuration

This app is impossible to obtain correctly without a google account. For example Gmail will have no issues from apkmirror but this app has to have the device specific config.

Split updates support

Thank you for considering!

thestinger commented 7 months ago

We don't include apps available from the Play Store.

MichaelDevon commented 7 months ago

Then can you tell me how do i even get this app without having to create a google account?

thestinger commented 7 months ago

All of this applies to every app from the Play Store. Why should we mirror every app in our app repository? It's unnecessary. Play Store is available there to use the sandboxed Play Store already.

This app is impossible to obtain correctly without a google account. For example Gmail will have no issues from apkmirror but this app has to have the device specific config.

You're wrong, and it's never safe to use it from apkmirror.

MichaelDevon commented 7 months ago

As i said. Many of your users use gcam who dont have play store.

Other apps dont depend on device specific config.

thestinger commented 7 months ago

As i said. Many of your users use gcam who dont have play store.

It comes from the Play Store and that's how you should get it. Play Store is a regular sandboxed app on GrapheneOS, so what's the issue?

Other apps dont depend on device specific config.

That's not true.

MichaelDevon commented 7 months ago

Seems like you didnt even read through my issue.

thestinger commented 7 months ago

If you want to participate in the GrapheneOS community including on GitHub, then stop.

MichaelDevon commented 7 months ago

That's not true.

Okay 0.000001% of apps do.

thestinger commented 7 months ago

Okay 0.000001% of apps do.

Every app using app bundles does, including all new apps and apps addressing the warnings caused by not using app bundles.

MichaelDevon commented 7 months ago

If you want to participate in the GrapheneOS community including on GitHub, then stop.

Okay sorry.

MichaelDevon commented 7 months ago

Any way to get it outside of play?

MichaelDevon commented 7 months ago

I cant make a google account.

thestinger commented 7 months ago

Why not? How do you think Aurora Store works? It fetches shared Google account credentials for accounts they create.

You can install Pixel Camera via Aurora Store as long as you disable the broken anonymous mode which avoids sending the device model and gets the wrong variants of apps in general. It's not at all specific to Pixel Camera. It just happens to be more broken than with most apps in the common case...

MichaelDevon commented 7 months ago

I don't use that store. Just because play store is sandboxed does not mean that i can just make an anonymous account randomly. I do not have a google account and its almost impossible to make one without a phone number.

thestinger commented 7 months ago

We're not going to mirror every app on the Play Store.

MichaelDevon commented 7 months ago

i understand that clearly. So if i somehow make a google account then can i use aurora store to obtain the correct version?

thestinger commented 7 months ago

You seem to be misunderstanding something. Aurora Store doesn't bypass the need for an account to use the Play Store. By default, it fetches shared account credentials for accounts they've created.

Turn off their broken anonymous mode. It retrieves the wrong variants of apps in general by not sending the device model in the requests.

MichaelDevon commented 7 months ago

Yes i get that. I just dont want google services to be installed on my device. So ill just get an account some way and log into aurora store.

I of course dont expect you to add every app to Apps. I thought it would make sense for some stock google apps to be there that most people will end up using anyway regardless of Play Services being installed as well.