search

GrapheneOS / AppStore

MIT License
268 stars 29 forks source link

Replace Glide with Coil #365

Open t895 opened 6 months ago

t895 commented 6 months ago

Closes #352

muhomorr commented 5 months ago

What's the impact on release APK size?

topminipie commented 5 months ago

2.7 megabytes commit 262277c 2.8 megabytes this PR

t895 commented 5 months ago

@topminipie Is right. I just ran a couple builds and got these results for APK size. main - 2759KBs coil - 2895KBs

muhomorr commented 5 months ago

What are the advantages of switching to Coil?

t895 commented 5 months ago

I generally prefer to use Coil in my Android apps nowadays because of the Kotlin-first syntax. Working with it in the Dolphin, Citra, and yuzu Android apps has been very plesant whether it be for loading images with the built-in options or creating custom loaders for the job.

As for performance or special features, I don't know of any advantages Coil has over Glide.

thestinger commented 5 months ago

It sounds like Coil is a nicer library, but we're just unsure if we want to move when it increases app size slightly without really offering any advantages for us. We'll need to think about it.

thestinger commented 5 months ago

Glide is still maintained. If it wasn't, it would be an easy decision to replace an unmaintained library.

t895 commented 5 months ago

That's fair I'll just leave this open if you ever become interested in it