Add non-cropping (4:3) aspect ratio options for video

GrapheneOS / Camera

Modern camera app focused on privacy and security with QR & barcode scanning.

https://grapheneos.org/

MIT License

836 stars 86 forks source link

Add non-cropping (4:3) aspect ratio options for video #222

Open ASerbinski opened 2 years ago

ASerbinski commented 2 years ago

Upstream bug submitted here; https://issuetracker.google.com/issues/232805590

thestinger commented 2 years ago

@ASerbinski There's https://issuetracker.google.com/issues/213957918 already.

ASerbinski commented 2 years ago

Comment 2 in that thread suggests that they're trying to implement alternative aspect ratios through additional cropping, which would be a lot more complicated and actually make things worse when all that is really needed is for them to add some additional entries to "Quality"

empratyush commented 6 months ago

there a new api for that setAspectRatio(AspectRatio.RATIO_16_9) added in 1.3.0

thestinger commented 4 months ago

Needs to be added back.