search

GrapheneOS / Camera

Modern camera app focused on privacy and security with QR & barcode scanning.
https://grapheneos.org/
MIT License
864 stars 89 forks source link

feat: russian localization added #316

Closed savely-krasovsky closed 1 year ago

savely-krasovsky commented 1 year ago

well, the commit message speaks for itself

thestinger commented 1 year ago

The strings need to be properly split out and there has to be a translation team for Russian formed. I can't review this since I don't know the language. No possible way for it to be merged. It's not complete due to lack of help splitting out the strings. We requested help with this and didn't get it. Someone started on it but didn't respond to code review and that PR will be closed too. All the work is wasted if it's not done in the way that's appropriate.

Roker2 commented 1 year ago

I can validate Russian language. I am from CarbonROM team and I helped Mokee some years ago with bad translation.

CakesTwix commented 1 year ago

I translate into Ukrainian and also know russian, so I can also validate the translation

savely-krasovsky commented 1 year ago

@Roker2 @CakesTwix we would probably then try to establish Russian translation team, maybe you are interested.

thestinger commented 1 year ago

We need to make translation teams. I think we need to make a Matrix room for each one. When there's a string change, I can ping all the rooms.

thestinger commented 1 year ago

We want to start by translating Camera, PDF Viewer, Auditor and Apps, i.e. our standalone applications. Could also include packages/apps/Updater (our OS update client). We don't want to initially try translating all of our OS code because it's hard for us to fit it into how we maintain it and port to new releases. We need to think about how to do that well.

We have high standards so we need multiple people including technical people to help with each language translation. We'll need to limit the number of languages to a reasonable amount.

Need to think about the best way to do it. The reason we want to start with standalone applications is because all the changes are from us and we aren't pressured to do releases based on time schedules not inside our control as we are with GrapheneOS and Vanadium where we have to quickly port to new major releases including strings and do a release. It's hard to see how we can fit production quality translations into anything based on AOSP. It's much more doable for Chromium because the code is almost all publicly available in the Beta channel, etc. for a while in advance but it would still be hard. We don't even fully remove the Google Chrome branding from Chromium yet due to the difficulty in maintaining that, even though we mostly automated it.

Roker2 commented 1 year ago

So, I and @CakesTwix made translations in @CakesTwix's weblate. You can also host it for your translation team.

CakesTwix commented 1 year ago

I recommend to use Weblate, an open source project for translations. There you can set up automatic sending of translations.

As I noticed, it was already mentioned, my Weblate is for personal use, so there is only Russian/Ukrainian

savely-krasovsky commented 1 year ago

So probably @thestinger can host Weblate or kinda so we can start (I am sure not only Russians/Ukranians are interested in localization).

I have some experience in Android development (mostly Flutter), but probably still can help technically.