search

GrapheneOS / Camera

Modern camera app focused on privacy and security with QR & barcode scanning.
https://grapheneos.org/
MIT License
801 stars 87 forks source link

Add 60 fps toggle to Camera app #397

Closed ghost closed 7 months ago

ghost commented 7 months ago

Hi! If interested, I've gone and added a "60fps" toggle to the camera app. I'm submitting this PR to see if there's interest in this feature, or something like it. The purpose is to enable higher frame rate video capture than the current default. Let me know your thoughts!

This change specifically adds a toggle to the Camera app allowing the user to record video at a higher frame rate ( 60fps ). The default is unchanged, and this setting is disabled by default.

It's possible that users might want a bit more flexibility, so they could set the frame rate in the "other settings" page, rather than in the inline menu, but I felt this was acceptable as a first attempt.

Related to https://github.com/GrapheneOS/Camera/issues/51

Screenshot:

screenshot

thestinger commented 7 months ago

It probably needs to detect the available frame rates and provide a choice rather than 1 toggle for this.

ghost commented 7 months ago

@thestinger I see, thank you for the feedback. I acknowledge that a toggle is not the best option. As far as UX, what is your preference?

One possibility is to show a screen with supported resolutions and framerates, like so:

image

Another could be the way OpenCamera does it, where they show:

image

thestinger commented 7 months ago

I'm not exactly sure. Not all frame rates can be used with all resolutions.

erkexzcx commented 7 months ago

Missing higher FPS (e.g. 60) is the only reason of why I am not using GrapheneOS Camera app... :( Would love to have 60fps.

ghost commented 7 months ago

This branch does work if you build + install using android sdk, at least on Pixel devices. I will consider a more general solution. Until then closing this PR.