GrapheneOS / os-issue-tracker

Issue tracker for GrapheneOS Android Open Source Project hardening work. Standalone projects like Auditor, AttestationServer and hardened_malloc have their own dedicated trackers.
https://grapheneos.org/
348 stars 19 forks source link

cannot turn off screen filters - extra dim, colour filter, colour inversion - pixel 6 #1437

Open wc2FiCLd opened 2 years ago

wc2FiCLd commented 2 years ago

after turning on colour inversion you cant turn it off. The switch goes OFF but the color inversion stays. Reboot fixes it once. Turning it on form the accessibility shortcut is the same. Picture attached - colours inverted but the toggle is OFF

I also have a bug report using adb bugreport, can attach it if it's needed and safe. Currently newest OS version, build number tp1a.220624.021.2022082400, device oriole - pixel 6.

PXL_20220828_201502829

wc2FiCLd commented 2 years ago

same goes for extra dim and color correction. Toggling any of them ON causes the other turned OFF filter to actually turn OFF, but you always stay with one of the filters working then its OFF. Seem like the whole screen filters feature is broken.

wc2FiCLd commented 2 years ago

extra dim work correctly, when colour inversion is ON. After turning colour inversion off, I can't see a change in brightness when toggling extra dim.

irgendwie commented 2 years ago

I can reproduce this issue.

irgendwie commented 1 year ago

Seems to be fixed with https://github.com/GrapheneOS/platform_manifest/releases/tag/TP1A.220905.004.A1.2022091300 ?

wc2FiCLd commented 1 year ago

The problem still exists for me after updating to tp1a.220905.004.a1.2022091400 right now My current workaround is to enable two filters, like extra dim, then you can freely change ONE filter. One will always remain enabled in the end.

14 Sept 2022, 20:37 by @.***:

Seems to be fixed with > TP1A.220905.004.A1.2022091400 https://github.com/GrapheneOS/platform_manifest/releases/tag/TP1A.220905.004.A1.2022091400> ?

— Reply to this email directly, > view it on GitHub https://github.com/GrapheneOS/os-issue-tracker/issues/1437#issuecomment-1247159210> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZE2HRJOCZPSKJ3YOIGLSTV6ILPTANCNFSM573UJVBQ> . You are receiving this because you authored the thread.> Message ID: > <GrapheneOS/os-issue-tracker/issues/1437/1247159210> @> github> .> com>

catdevnull commented 1 year ago

This happens to me today in Pixel 7. TD1A.220804.031.2022102800

vytskalt commented 1 year ago

Same issue. Pixel 6a 13 (TP1A.221005.003)

qdrop17 commented 1 year ago

I can also confirm this issue; TP1A.221105.002.2022110800 on Pixel 6 Pro.

c3piio commented 1 year ago

I can also confirm this issue on Pixel 6a TP1A.221105.002.2022112500

Zeit08 commented 1 year ago

Yes, I also confirm that color correction and extra dim do not turn off after toggling them off. Only reboot fixes it. Pixel 6a, updated today to TP1A.221105.002.2022113000

gianklug commented 1 year ago

Can reproduce on Pixel 7 / TD1A.221105.001.2022113000

FrenchToucan commented 1 year ago

Can reproduce on Pixel 6 Pro / TQ1A.230105.002.2023010300

FrenchToucan commented 1 year ago

Did this get fixed in the latest build?

Issue is not present on Pixel 6a / TQ1A.230105.001.A2.2023011000

thestinger commented 1 year ago

There were no relevant changes beyond enabling adaptive brightness by default.

FrenchToucan commented 1 year ago

Yeah, I was mistaken, it's not fixed. Right now, the behavior I'm seeing is that color correction ON only returns to the correct color palette if Extra Dim is turned on.

wc2FiCLd commented 1 year ago

You can turn on/off any number of screen filters, but in the end the last one will NOT be turned off. The issue is confirmed on many versions, I don't think it's necessary to confirm it further. 13 Jan 2023, 15:42 by @.***:

I was mistaken, it's not fixed. Right now, the behavior I'm seeing is that color correction ON only returns to the correct color palette if Extra Dim is turned on.

— Reply to this email directly, > view it on GitHub https://github.com/GrapheneOS/os-issue-tracker/issues/1437#issuecomment-1381953855> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZE2HRLYA4IECTFQ3YFSZTWSFSVHANCNFSM573UJVBQ> . You are receiving this because you authored the thread.> Message ID: > <GrapheneOS/os-issue-tracker/issues/1437/1381953855> @> github> .> com>

FrenchToucan commented 1 year ago

You can turn on/off any number of screen filters, but in the end the last one will NOT be turned off. The issue is confirmed on many versions, I don't think it's necessary to confirm it further. 13 Jan 2023, 15:42 by @.***: I was mistaken, it's not fixed. Right now, the behavior I'm seeing is that color correction ON only returns to the correct color palette if Extra Dim is turned on. — Reply to this email directly, > view it on GitHub <#1437 (comment)>> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZE2HRLYA4IECTFQ3YFSZTWSFSVHANCNFSM573UJVBQ> . You are receiving this because you authored the thread.> Message ID: > <GrapheneOS/os-issue-tracker/issues/1437/1381953855> @> github> .> com>

I just confirmed that this isn't the behavior I'm seeing. On my Pixel 6a TQ1A.230105.001.A2.2023011000, I turned on Extra Dim then turned on Grayscale (worked correctly) and turned off Grayscale (worked correctly).

Edit: I forgot Extra Dim is a filter. And yes, you're right, removing that as a final step doesn't work correctly. Thanks

wc2FiCLd commented 1 year ago

When one effect is on, you can turn on/off any other effects correctly. I wrote that in 2nd post after crearing this thread. Bug is marked as upstream.


pozdrawiam
Dawid Sęczkowski

13 Jan 2023, 15:55 by ***@***.***:

>
>
>
>
>>
>>
>>
>> You can turn on/off any number of screen filters, but in the end the last one will NOT be turned off. The issue is confirmed on many versions, I don't think it's necessary to confirm it further. 13 Jan 2023, 15:42 by >> @>> .***:
>> … <>
>> I was mistaken, it's not fixed. Right now, the behavior I'm seeing is that color correction ON only returns to the correct color palette if Extra Dim is turned on. — Reply to this email directly, > view it on GitHub <>> #1437 (comment) <https://github.com/GrapheneOS/os-issue-tracker/issues/1437#issuecomment-1381953855>>> >> , or > unsubscribe >> https://github.com/notifications/unsubscribe-auth/A2ZE2HRLYA4IECTFQ3YFSZTWSFSVHANCNFSM573UJVBQ>> > . You are receiving this because you authored the thread.> Message ID: > <>> /issues/1437 <https://github.com/GrapheneOS/os-issue-tracker/issues/1437>>> /1381953855> @> github> .> com>
>>
>>
>>
>>
>
> I just confirmed that this isn't the behavior I'm seeing. On my Pixel 6a TQ1A.230105.001.A2.2023011000, I turned on Extra Dim then turned on Grayscale (worked correctly) and turned off Grayscale (worked correctly).
>
>
>
>
> —
> Reply to this email directly, > view it on GitHub <https://github.com/GrapheneOS/os-issue-tracker/issues/1437#issuecomment-1381978892>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/A2ZE2HSJPXJCXB3X27YB2HTWSFUFXANCNFSM573UJVBQ>> .
> You are receiving this because you authored the thread.> Message ID: > <GrapheneOS/os-issue-tracker/issues/1437/1381978892> @> github> .> com>
>
>
>
>
Alerymin commented 1 year ago

This bug also happens with "Extra dim" and breaks forever (even after reboot) background dimming when there is a popup window (like the power menu)

Alerymin commented 1 year ago

Found it thanks to the Matrix room

I needed to switch color mode from "Saturated" so something else and now everything is fixed

Swoooshhh commented 1 year ago

I've found a work around, turn on nightlight and then try disabling it, for some reason you can only toggle the color filter when nightlight is enabled.

And then you can turn nightlight off and you'll have color back. You can turn the color filter on again but you'll need to enable nightlight again to disable it again.

Swoooshhh commented 1 year ago

Found it thanks to the Matrix room

I needed to switch color mode from "Saturated" so something else and now everything is fixed

This fixed it for me

c3piio commented 1 year ago

Found it thanks to the Matrix room I needed to switch color mode from "Saturated" so something else and now everything is fixed

This fixed it for me

Fixed for me too

sereksim commented 1 year ago

@wc2FiCLd

[...] Bug is marked as upstream. [...]

Does that mean the bug is not caused by GrapheneOS but by the AOSP source? If so, has someone already created an issue at their issuetracker? At first glance, i could not find one in the Accessibility category-> https://issuetracker.google.com/issues?q=componentid%3A1161519%2B

zzzzz-attachment commented 11 months ago

Workaround working Setting -> Display ->Colour -> Change Saturated to something else Use night light button to disable colour conversion without reboot

The issue is still open in current graphene OS for pixel 6a

ZaneBartlett1 commented 11 months ago

@wc2FiCLd

[...] Bug is marked as upstream. [...]

Does that mean the bug is not caused by GrapheneOS but by the AOSP source? If so, has someone already created an issue at their issuetracker? At first glance, i could not find one in the Accessibility category-> https://issuetracker.google.com/issues?q=componentid%3A1161519%2B

Thank you sereksim, since there hasn't been any response on that comment in the past month, it was labeled upstream a year ago, and I couldn't find mention of it anywhere else outside of accessibility issues, I went ahead and started one. Here is a link to it - https://issuetracker.google.com/issues/302210609. If this is effecting you, I think the best thing to do is to go to the link and click the +1 in the top right

image

thestinger commented 11 months ago

You need to make it clear in the issue that people have replicated it with AOSP and that it's not a GrapheneOS issue. We don't know if it occurs with the current stock Pixel OS since they replace components including Settings, but it would be worthwhile testing it. An issue can occur on AOSP and GrapheneOS but not the stock OS due to them using an extended Google Settings, SystemUI, etc. but for the most part AOSP issues not in the AOSP sample apps occur on the stock Pixel OS.

ZaneBartlett1 commented 11 months ago

Ah, my bad. I can't confirm that it's happening on a stock Pixel right now, should I delete it, or can you point me to examples of that I could update the issue with?

thestinger commented 11 months ago

I don't think you can delete issues. If someone can confirm it occurs on the stock Pixel OS, that would be great. It doesn't have to be you. I know it's an AOSP issue but I don't know if they've fixed it in their Settings app or with some change we don't have included for resources.

catdevnull commented 11 months ago

I have not noticed it at all with stock for the past month or so (and it happened fairly often in GOS) although I am running 14 Beta. I'm pretty sure it's not in stock though; I read it a few times in GOS char rooms but never related to stock

matrixneo135 commented 11 months ago

Writing to confirm that this issue persists. Accessibility settings will not turn off on newest GrapheneOS Android 14 release.

MemoryFreezer commented 10 months ago

Can confirm too - Pixel 6a - UP1A.231005.007.2023101100

You can revert too if you switch the profile back and forth... if you use more then two.

Any comment/outlook regarding priority of this issue?

catdevnull commented 10 months ago

I have been using A14 stock for quite a few months now and never ever noticed it.

matrixneo135 commented 10 months ago

I wanted to provide an update to my previous report:

I made my report after freshly installing GOS on a brand-new Pixel device. After setting up and using the device for a few days, I can no longer reproduce the issue on my device. I've been using Extra dim, Color correction, Color inversion, and Night Light over the last few days. At first, I was experiencing the same issues others reported (you could disable one screen filter by enabling another screen filter, but the last filter used would always stay enabled until a reboot even when switched to the "OFF" state). Now, the issue has worked itself out. I wish I could provide more info as to why that is the case, but I'm not entirely sure what fixed it.

I suspect it has something to do with the Night Light feature. I noticed that the issue disappeared soon after a few day-night cycles with the scheduled Night Light feature enabled.

flolu commented 10 months ago

I can confirm the problem is still present on Pixel 8 Pro (husky)

RXTX4816 commented 10 months ago

The issue still persists on currently newest version. Simulate color correction cannot be turned off, a reboot while it being off is the only way to see the colors.

c3piio commented 10 months ago

I don't have this problem anymore on pixel 6a. I can turn on and off color correction, color inversion, and extra dim. No issues for several versions.

ZaneBartlett1 commented 10 months ago

I am still experiencing this issue with android 14 on Pixel 6a

ZaneBartlett1 commented 9 months ago

So something odd I've noticed now - Night Light - Can be turned on and off correctly without restarting phone. This is great, and now I've turned on the night light schedule! Color correction - Still won't turn off once turned on. However NOW I can turn on Night Light when it's stuck, then turn off night light, which fixes it. Faster than a phone restart at least. It honestly almost seems like if in color correction, you had "default" color correction, you could just leave the setting on. It'll switch correctly between selections, it just won't turn off once you want it to. So I think if instead of turning it off, you just had to reset it to default, that would be a fix?

heuwerk commented 8 months ago

I can reproduce this bug with color correction on Pixel 8 (Build UQ1A.231505.015.2023120800) but it works fine on my Pixel 5 (UP1A.231105.001.2023120400).

So something odd I've noticed now - Night Light - Can be turned on and off correctly without restarting phone. This is great, and now I've turned on the night light schedule! Color correction - Still won't turn off once turned on. However NOW I can turn on Night Light when it's stuck, then turn off night light, which fixes it.

I have also had this experience. This "fix" also works on my Pixel 8 for the extra dark mode, which remains active after switching off and on at most three times (until I switch on the night light).

yaomtc commented 2 months ago

Experiencing this issue with my Pixel 6a, stable channel. I wanted to try grayscale mode but then I get stuck with one of the four color correction options.

yaomtc commented 2 months ago

OK, after a reboot the quick settings tile is now working correctly. It turns color correction on and off unlike before.

thestinger commented 2 months ago

There are known upstream bugs with it which cause it to get stuck until reboot. Reboot should always fix it.

yaomtc commented 2 months ago

Thanks, I found the issue tracker link, though it has been labeled as "Won't fix (Obsolete)". I wonder if the AOSP developers will even see it, in that case...