GrapheneOS / os-issue-tracker

Issue tracker for GrapheneOS Android Open Source Project hardening work. Standalone projects like Auditor, AttestationServer and hardened_malloc have their own dedicated trackers.
https://grapheneos.org/
356 stars 21 forks source link

wallpaper stretched on secondary users #1461

Open 0xspade opened 2 years ago

0xspade commented 2 years ago

Wallpaper is stretched in home screen but seems okay when setting up in wallpaper setting.

bigswag420 commented 2 years ago

what device and version? i cant reproduce on 6

0xspade commented 2 years ago

what device and version? i cant reproduce on 6

Pixel 6 Pro

charlycoste commented 2 years ago

Same for me on my Pixel 6 Pro (build: TP1A.220624.021.2022090400) Wallpaper seems OK on preview, but stretched when applied. The strange thing about it is that everything was OK before upgrading to Android 13.

Preview image Applied image
bigswag420 commented 2 years ago

theres a relevant forum thread about this

Leonetienne commented 1 year ago

I am experiencing this issue aswell on TD1A:221105.001.2022111000 on a P7P, but only on secondary profiles. For the owner profile, it works fine (with the exact same image file). (Sorry I don't know how to make the images appear inline). I am using a humanoid, because for some reason using a grid did not stretch it. Maybe because humans are just really good at detecting deformed humans..?

preview actual-wp

akc3n commented 1 year ago

@Leonetienne it's an upstream related bug.

I am experiencing this issue aswell

( https://github.com/GrapheneOS/os-issue-tracker/issues/1461#event-7373161617 )

InFarAday commented 1 year ago

Any news on this? It's definitely not a priority but I've resorted to the black wallpaper because my usual wallpaper looks gross.

KJ7LNW commented 10 months ago

+1, having the same problem on a Pixel 6 Pro.

KJ7LNW commented 10 months ago

Someone from the discussion thread said that "if anyone is still having this issue, take the photo you want fixed, edit in the wallpaper app, then export with a width of 1344. Use that photo as your wallpaper."

It works! Not sure why...but it works! oops...spoke too soon. It doesn't work, I was still on the preview page and didn't realize it.

thestinger commented 10 months ago

The width depends on the device.

KJ7LNW commented 10 months ago

@thestinger , any idea what the width should be scaled to for the Pixel 6 Pro?

SyntheticBird45 commented 10 months ago

I had same issue on Pixel 5, and now same issue on Pixel 7. This issue is the definition of mildlyinfuriating. It's so small but still so annoying. I've been dealing with this for 2 years now. The only workaround I found was using a static image as a live wallpaper, but it don't work anymore. I don't expect devs to come and fix shitty things but if at least we could get an answer on what might be the issue here, so we don't look like we're being forgotten. The use of user profiles is encouraged, but such deficiency can't be ignored away.

thestinger commented 10 months ago

It's not a GrapheneOS specific issue and we don't have the resources to fix every upstream bug. We focus on fixing bugs and compatibility issues that are specific to GrapheneOS, which are highly prioritized and generally get fixed very quickly. AOSP issues not impacting other Android operating systems for some reason are also prioritized. Issues which are cross-platform are only prioritized if they're severe, otherwise it's not really up to us to deal with it. You can choose the priorities of your own development work or a developer you hire. You're all welcome to do that. You can find someone willing to work on this and pool money to pay them, but we're not going to be involved since we have much more important things to work on.

thestinger commented 10 months ago

It's also possible that this could be worked around by documenting the height/width for each device where it doesn't happen. Someone could work on figuring that out without being a developer, and then it could be documented so people can edit images to the appropriate size for their device and avoid it.

KJ7LNW commented 10 months ago

It's not a GrapheneOS specific issue and we don't have the resources to fix every upstream bug.

Interesting. Is there an upstream bug report that can be referenced here?

Can someone reproduce this on AOSP? If so, then we should definitely open a ticket there.

I think someone mentioned that it works on the "Owner" profile but not on other profiles. I'll verify when I have access to that phone again.

polzon commented 9 months ago

I finally found a way to trigger this bug and a way to work around it. Here's my setup:

My main profile is two screens wide. It was set to a dynamic wallpaper app called Muzei. My secondary profile is only one screen and the wallpaper is simply static image using the stock Wallpaper & style app. This secondary profile wallpaper has the stretch issue that is this bug report. Both of these profiles had their wallpapers set to home and lock screen.

On my main profile, instead I tried swapping it to a static image with the Wallpaper and style app. This seemed to fix the stretching bug in my secondary profile.

When I went back to my main profile and set it back to the Muzei dynamic wallpaper, it again consistently triggers the stretch bug on my secondary profile.

Hope this info helps people work around and reliably reproduce this bug. This annoying bug has plagued me ever since I got the Android 14 update on my Pixel 6a, and still persists on my Pixel 8.

Edit: Upon further testing, if I do the same setup of a static picture on main profile lock/home screen, then if I were to go to my secondary profile. When I set the second profile's static wallpaper to an image and choose to apply to both "Home and lock screen", the stretch issue is fixed. However if I do two different static images for the home and lock screen, just the lock screen wallpaper will become stretched.

Wallpaper size does not seem to apply, as I tested this by manually choosing the same static image on both lock and home screen. So doing it once and choosing apply to "home", and then again, but choosing apply to "lock screen". Despite being the same exact image, the lock screen will still stretch unless the option apply to "Home and lock screen" is explicitly pressed.

With further testing, going back to my main profile and choosing the dynamic wallpaper app Muzei, the stretch bug again appears on the secondary profile. This stretch bug now affects both the home screen and lock screen. All of this behavior is reproducible for me, so applying the static wallpaper to my main profile also consistently fixes it in the secondary profiles.

I have a total of three profiles, and this behavior is consistent on both non-main profiles. This was all tested on a Pixel 8 running GrapheneOS version 2023123100.

aidenzzz commented 9 months ago

It's also possible that this could be worked around by documenting the height/width for each device where it doesn't happen. Someone could work on figuring that out without being a developer, and then it could be documented so people can edit images to the appropriate size for their device and avoid it.

A working fix for this is to resize the image to the resolution of your phone with the width multiplied by two.

ex. Pixel 6 screen has a resolution of 2400 x 1080. Your image should be resized 4800 x 1080. I did this using black bars to not ruin the aspect ratio. Here's a link showing the images before, after resizing, and applied as the wallpaper.

This isn't a perfect fix, but it was the best I could come up with after experimenting. If you have multiple pages of apps, switching to the next page will show the black bars rather than your wallpaper. I'm not familiar with AOSP, but I'm assuming the bug is related to the resizing for the sliding wallpaper.

mloveys commented 8 months ago

The workaround I found is done by setting the wallpaper on the main profile with the same name as other profiles. What I did is set a wallpaper on my main profile with the name Wallpaper.jpg then switched over to my second profile and named another image Wallpaper.jpg and didn't see the zooming problem occur as long as the file name matched with the one set on the main profile

polzon commented 8 months ago

Having this on other ROM as well, I suspect it's a ASOP issue. Also, now I can't even use the gesture to go home on other profiles it's completely broken after update. Has anyone reported this to ASOP upstream? Profiles have been so broken for years and nothing has been done, does Google even care?! What spaghetti code causes this? Profiles are completely unusable now, I can't do anything

I was forced to go back to stock Pixel Android for the time being, and can confirm that this super annoying wallpaper bug still exists on there as well.

thestinger commented 8 months ago

I was forced to go back to stock Pixel Android for the time being, and can confirm that this super annoying wallpaper bug still exists on there as well.

Why were you forced to go back to the stock OS?

polzon commented 8 months ago

I was forced to go back to stock Pixel Android for the time being, and can confirm that this super annoying wallpaper bug still exists on there as well.

Why were you forced to go back to the stock OS?

Sorry this is getting off topic, but for the time being until I find a work around, I had to swap back to get my MDM apps working in my work profile. This goes into it better then I can explain. You can see on my GitHub I have a super amateur bash script to force copy the play store into the work profile, but installing the internal apps from managed play store was the barrier I couldn't pass since the MDM policy blocks installation from 3rd party app stores.

Netpilgrim commented 5 months ago

On my main profile, instead I tried swapping it to a static image with the Wallpaper and style app. This seemed to fix the stretching bug in my secondary profile.

Thank you! Setting a wallpaper on the main profile fixed it for me as well. On second glance, not completely—some horizontal stretching is still there, together with more zoom-in than with the standard Google Android. (The latter also zooms in slightly by design so the wallpaper can be zoomed out again when swiping down notifications.)

altinthaqi commented 2 months ago

Setting the same wallpaper on both homescreen and lockscreen usually does the trick, but If you want to have different wallpapers for your lock/home than worked for me was:

you should now have different home/lock unstretched wallpapers : )

heyyhc commented 1 month ago

On the P7P, running Android 14, Build: 1014091900

After setting a different wallpaper for both the Home & Lock screen(on the primary account), the secondary user's Home & Lock screen wallpapers sizes seem to have corrected itself(is no longer stretched).