Open p1gp1g opened 11 months ago
I am having this issue too.
Confirmed for English and German as well.
Possible dupe of #247 and #518.
It's a duplicate in the sense that this issue existed before and we previously fixed it but the reason it's happening now is because the fix was incompatible with Android 14 and had to be reverted. Use another keyboard for now.
It's a duplicate in the sense that this issue existed before and we previously fixed it but the reason it's happening now is because the fix was incompatible with Android 14 and had to be reverted. Use another keyboard for now.
I also get this issue with another keyboard, OpenBoard in my case:
(Pixel 6 with Android 14)
From what I can tell OpenBoard does not have a built in spell checker or anything, so it seems that 3rd party keyboards are also be affected.
My system spell checker is configured to use system languages, which are 1) US and 2) German (qwerty)
I also have the same issue for Russian words with English as default system language and AOSP keyboard with English and Russian layouts. It turns out that disabling system spell checker while leaving keyboard's one enabled solves problem for me. Pixel 5a Android 14
The release notes for version 2023103100 mention in the changelog that this issue was supposed to be fixed. However, I don't know if I'm doing anything wrong but for me the problem persists. The spell checker only seems to use the primary system language (the language at the top of the list of the selected system languages) and none of the secondary system languages.
I am currently running build UP1A.231105.003.2023110700 and have the problem both with the default GrapheneOS keyboard and OpenBoard.
OpenBoard needs to resolve the issue themselves.
It's not a problem with OpenBoard though. As I already mentioned I still have the same problem when I switch back to the default OS keyboard. And on the forums there is at least one person with the same problem who isn't using OpenBoard: https://discuss.grapheneos.org/d/8767-spell-checker-not-working-for-secondary-languages
Maybe one of people who mentioned earlier in this issue that they have the same problem can comment if the problem has been fixed for them? For example, @p1gp1g , @NoisyCoil , @j-lakeman or @hcording ?
The issue is fixed for me.
The issue is fixed for me.
Thanks for commenting @scarecrow1636. Could you maybe share your some relevant details of your setup, i.e. which keyboard you're using, build version, settings (keyboard, languages, spell checker)? Then I might be able to check how they differ from mine.
The issue is fixed for me.
Thanks for commenting @scarecrow1636. Could you maybe share your some relevant details of your setup, i.e. which keyboard you're using, build version, settings (keyboard, languages, spell checker)? Then I might be able to check how they differ from mine.
I'm using default keyboard. System languages are English (United States) and Russian (Russia). My spell checker is set to default and configured to use system languages. I was previously affected by the issue.
UP1A.231105.003.2023110700
I did some more tests, also adding additional secondary languages and the problem seems to be with my main secondary language, Dutch. If I add other languages like German and French the spell checker does work for those. Interestingly if I make Dutch my primary system language (so that the entire OS is in Dutch) the spell checker seems to stop working all together (in the sense that it never seems to flag any word as being wrong, even if I just write any garbage string of letters, regardless of the secondary languages activated). Is it possible that the update to Android 14 somehow broke the Dutch dictionary?
It's not a problem with OpenBoard though. As I already mentioned I still have the same problem when I switch back to the default OS keyboard. And on the forums there is at least one person with the same problem who isn't using OpenBoard: https://discuss.grapheneos.org/d/8767-spell-checker-not-working-for-secondary-languages
Maybe one of people who mentioned earlier in this issue that they have the same problem can comment if the problem has been fixed for them? For example, @p1gp1g , @NoisyCoil , @j-lakeman or @hcording ?
It's a per-keyboard issue. We previously had a workaround applied in the OS which was an ugly hack and isn't going to be done anymore on Android 14. Most keyboards are not impacted by leaving out the ugly workaround.
I did some more tests, also adding additional secondary languages and the problem seems to be with my main secondary language, Dutch. If I add other languages like German and French the spell checker does work for those. Interestingly if I make Dutch my primary system language (so that the entire OS is in Dutch) the spell checker seems to stop working all together (in the sense that it never seems to flag any word as being wrong, even if I just write any garbage string of letters, regardless of the secondary languages activated). Is it possible that the update to Android 14 somehow broke the Dutch dictionary?
There isn't dutch spellchecking support in AOSP keyboard.
I did some more tests, also adding additional secondary languages and the problem seems to be with my main secondary language, Dutch. If I add other languages like German and French the spell checker does work for those. Interestingly if I make Dutch my primary system language (so that the entire OS is in Dutch) the spell checker seems to stop working all together (in the sense that it never seems to flag any word as being wrong, even if I just write any garbage string of letters, regardless of the secondary languages activated). Is it possible that the update to Android 14 somehow broke the Dutch dictionary?
There isn't dutch spellchecking support in AOSP keyboard.
Really? You would kind of expect that it's there considering you can choose Dutch as a system language and as a keyboard language with the AOSP keyboard. Too bad. Then I guess my best solution for now is just to disable the spell checker and hope they improve Dutch support in AOSP keyboard at some point.
Thanks for explaining the situation in any case!
You can use a different keyboard with the features you want.
Thanks for the suggestion, I might look into that at some point. For now turning it off is fine for me since I was never relying much on the spell checker anyway.
I confirm the bug still persists on:
Pixel 6a GrapheneOS 2023110700 Default system keyboard
System language is italian. On Settings->System->Keyboard->On-screen Keyboard I have selected English (USA) and italian. On Settings->System->Keyboard->Spell Check->Languages I have selected "Use system languages"
If I select English while typing on the keyboard, all words are underlined in red.
Resolved for upcoming OS release.
The problem still persists for me on 20231231.
@mxkrsv Can you give more details?
I'm using a beta channel build on a Pixel 6a.
When the main system language is English, the words in the second language are always highlighted red, both with "use system languages" in keyboard settings and without. When the system language is swapped, it's vice versa (English words are red).
It may be relevant that adding a highlighted word to a dictionary actually adds it to the English one.
@mxkrsv Are you using the default keyboard and default spell checker?
Yes. No other OS modifications either.
My setup is same as the above. Latest stable on 6a. All Russian words are underlined since this morning.
Same on:
@RobinFrcd What's the value of the spell checker's "Languages" setting (in Settings -> System -> Keyboard -> Spell checker)?
Use system languages
@muhomorr
@RobinFrcd Does it happen with all English and French words? It happens to me only for French words that start with a non-English letter.
@mxkrsv @scarecrow1636 I've reproduced the issue, it's due to incorrect handling of word splitting when languages with non-similar alphabets are used together.
Well, the issue on my side is mainly that I'm not getting French words suggestion at all, only English ones.
@RobinFrcd Did multi-language suggestions work for you before with the same setup?
I installed GOS for the first time yesterday, was on LineageOS before, had no issue with this setup. @muhomorr
You probably weren't on Android 14.
I'll double-check when I'm at home, but I think you're right. I guess it was Android 13. But still, we can agree it's a bug here, right ?
There was a regression caused by Android 14, which we've been working on resolving.
Spell checker behavior should be the same as it was in Android 13 since 2024010400 release.
With:
This is not working the same as my OP6 on LineageOS (Android 13).
On the Pixel, the keyboard only suggests/corrects English words (but doesn't underline French words, tho). On Android 13 it uses both languages.
@RobinFrcd What are language settings for Gboard spell checker? Gboard spell checker was not affected by this issue.
@muhomorr Using System languages (1. English 2. French)
Oh, actually have the same issue with default Spell Checker. But maybe there's a "learning" process ? I have a few French words that pop in the suggestions, but most of the time it's only English, even if the full word exists in French.
Example:
Cest
, I have C'est
as first suggestion which is greatMerci
I get Merciful
as first suggestion@RobinFrcd I'm unable to reproduce this on 2024010400 release. Are you switching keyboard layout to French when writing French words?
I'm using the French (France)
Gboard in QWERTY
with Mulitlingual typing
and English (UK)
enabled.
Built-in spellchecker is not used for suggestions when Gboard is used, it's used only for spell-checking in that case.
Oh, thanks, I'm a bit lost then, in that case the suggestion mechanism in based on which system ?
Suggestions come from Gboard. Try to reproduce this issue with built-in keyboard + built-in spellchecker.
Spell checker behavior should be the same as it was in Android 13 since 2024010400 release.
Fixed on my side, thanks.
I still have issue with the words suggestions not working on my secondary language. Not sure where to look at, is it only an issue on gboard side ? Nothing to do with the system here ?
@RobinFrcd Have you revoked the Network permission from Gboard? Gboard needs it to download dictionaries.
Until Android 14 release, the spell checker used the keyboard language to check the input. Now it seems to only use the system language, or the one defined in spell checker settings, making it pretty impossible to switch easily.
For instance, if you use:
And you type "Ceci est un exemple en français", then every words are underlined. Even if each of them are suggested by the keyboard (cf. screenshot).