search

GrapheneOS / os-issue-tracker

Issue tracker for GrapheneOS Android Open Source Project hardening work. Standalone projects like Auditor, AttestationServer and hardened_malloc have their own dedicated trackers.
https://grapheneos.org/
363 stars 21 forks source link

replace Gallery app #48

Open thestinger opened 5 years ago

Sortova commented 5 years ago

On my Pixel 3 the Gallery app will crash when trying to edit a picture. Here is the log.

gallery-edit.txt

Update: I installed Simple Gallery Pro from F-Droid and its editor does not have this issue.

gcbrown commented 4 years ago

Hey @thestinger, I'm looking to help out with GrapheneOS. I don't have any security background whatsoever, but I am certainly able to work on apps that aren't critical to security/privacy. I see that the Gallery needs work, but I'm wondering if there is something more important I could work on as well. Are the camera, calendar, contacts, etc. especially in need of improvement? Please let me know what you think.

theaeonsolution commented 4 years ago

You should try joining the project's official chat room. That's where we generally discuss the project with the community.

@gcbrown you're on the right track by looking at the issue tracker, I would suggest finding something you are comfortable working on and submitting a pull request. It doesn't have to be about security/privacy. The project could use some help with Vanadium for general housekeeping and I'd be happy to help you get started there if that looks interesting to you. Just reach out to me on the channel.

thestinger commented 4 years ago

Simple Gallery Pro is GPLv3 so we cannot include it in the permissively licensed GrapheneOS project. It would forbid things we want to permit such as making a locked down device with GrapheneOS.

thestinger commented 3 years ago

It's also concerning that Simple Gallery Pro uses a closed source photo editor which appears to be incompatible with GPLv3. The open source builds omit that and have a very limited editor which is not going to be improved anymore. We want to use a gallery app that's not taking an open core approach like that.

dhishkyaon commented 3 years ago

@thestinger also the default gallery app in GOS requires access to all files which doesn't make any sense imo. This should be changed.

thestinger commented 3 years ago

We're going to be replacing the app, not developing it.

theaeonsolution commented 3 years ago

I appreciate you trying to offer solutions. Join the project's official chat room if you want to discuss solutions with the community. Also, please read contacting the project and follow the guidelines there.

dhishkyaon commented 3 years ago

I think this app can replace the default gallery app.

theaeonsolution commented 3 years ago

I think this app can replace the default gallery app.

@dhishkyaon please use the project's official chat room to discuss this further with the community. See the links from my previous response to your deleted comment for more information.

ghost commented 2 years ago

Please replace the gallery app asap. Thanks !

duck09 commented 2 months ago

Is the new Gallery app planned to use the "Markup" application for photo editing or will it have its own photo editor?

thestinger commented 2 months ago

Markup isn't going to be included in GrapheneOS, so it needs to have an editor itself.

duck09 commented 2 months ago

Markup isn't going to be included in GrapheneOS, so it needs to have an editor itself.

Good stuff. Markup app is pretty minimal in terms of features.

randomwithnoname commented 2 weeks ago

https://github.com/IacobIonut01/Gallery has a built-in editor in the latest stable release.

duck09 commented 2 weeks ago

https://github.com/IacobIonut01/Gallery has a built-in editor in the latest stable release.

The question is, does it have all the necessary intents needed to replace the AOSP Gallery?