search

GrapheneOS / os-issue-tracker

Issue tracker for GrapheneOS Android Open Source Project hardening work. Standalone projects like Auditor, AttestationServer and hardened_malloc have their own dedicated trackers.
https://grapheneos.org/
348 stars 19 forks source link

Extend Sandboxed Play Services location requests rerouting to sensors #991

Open gordonel opened 2 years ago

gordonel commented 2 years ago

Navigation apps may also use sensors for inertial tracking and live compass. Right now, compass and inertial tracking doesn't work if Play Services are denied sensors permissions. To reproduce:

  1. Enable "Reroute location requests to the OS APIs"
  2. Revoke location permissions for Google Play Services, but allow Sensors permissions
  3. Launch an app that uses live compass or inertial tracking (e.g. Google Maps, Sensors must be allowed for the app)
  4. Check if your location dot has working live compass
  5. Revoke Sensors from Play Services
  6. Restart the navigation app

You won't see live compass

x5444 commented 4 months ago

Not sure when this happened but lately it seems that even when Google Play Services has Sensors persmissions granted, compass/directional location in Google Maps doesn't work when Location is routed through OS.

It seems to me (and this may be an incorrect conclusion) that compass needs to also be routed through the OS and not left to Google Play Services to handle.

I didn't want to make this a new issue because I'm basically asking for the same thing as OP. Please let me know if I can do anything to help testing/verifying/reproducing the issue.

x5444 commented 4 months ago

Not sure when this happened but lately it seems that even when Google Play Services has Sensors persmissions granted, compass/directional location in Google Maps doesn't work when Location is routed through OS.

It seems to me (and this may be an incorrect conclusion) that compass needs to also be routed through the OS and not left to Google Play Services to handle.

I didn't want to make this a new issue because I'm basically asking for the same thing as OP. Please let me know if I can do anything to help testing/verifying/reproducing the issue.

This was fixed in GmsCompat Version 108. Thank you! https://github.com/GrapheneOS/platform_packages_apps_GmsCompat/releases/tag/config-108

The original enhancement request still stands as far as I can tell.

thestinger commented 4 months ago

Yes, the original request is still relevant and it's planned.