search

GrapheneOS / platform_packages_apps_SetupWizard2

MIT License
3 stars 7 forks source link

add check for Seedvault #25

Closed dot166 closed 8 months ago

dot166 commented 8 months ago

if (somehow) Seedvault is missing the SuW will crash. this fixes that problem by showing an alert dialog saying it crashed and outputting the error to the log and letting the user try again or skip the migration step.

quh4gko8 commented 8 months ago

Need to drop the merge commits, and preferably store the strings in strings.xml, and grab its value using Context#getString. Similarly, intent action and flattened component names can be stored in config.xml to allow easier replacement thereof when the new backup app is implemented

dot166 commented 8 months ago

Need to drop the merge commits,

done

dot166 commented 8 months ago

and preferably store the strings in strings.xml, and grab its value using Context#getString. Similarly, intent action and flattened component names can be stored in config.xml to allow easier replacement thereof when the new backup app is implemented

done

dot166 commented 8 months ago

Need to squash the commits, along with declaring strings like intent actions as field instead of inlining them for readability.

done

matchboxbananasynergy commented 8 months ago

Hi @jf916. We have decided not to proceed with this PR at this time, but we do appreciate your interest in contributing.

In the future, in order to ensure that the process is more efficient, it would make sense to open an issue first instead of a PR to make a proposal and whether something is wanted can be discussed.

For cases where an issue already opened, you can comment on it and discuss details of implementation and also ensure that nobody else is working on it at the time or plans to work on it.

Thanks again!