search

GrapheneOS / talkback

Apache License 2.0
11 stars 3 forks source link

Build changes #1

Closed ghost closed 2 years ago

ghost commented 3 years ago
PatrykMis commented 2 years ago

Build failed.

> Task :processReleaseMainManifest FAILED
C:\talkback-foss\src\main\AndroidManifest.xml Error:
        android:exported needs to be explicitly specified for <service>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':processReleaseMainManifest'.
> Manifest merger failed : android:exported needs to be explicitly specified for <service>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
ghost commented 2 years ago

Need to work out some things I looked over. Thank you for testing. Didn't catch some of this stuff. @PatrykMis

Don't merge yet.

ghost commented 2 years ago

Doubt I can work on this. I have no proper way of testing this because targeting SDK 31 requires some code changes relating to intents and possibly more. Especially since users rely on Talkback here.

And I don't have a secondary device to test with. Android Studio emulator isn't that great.

PatrykMis commented 2 years ago

If you are able to work on it, I can actively test.

ghost commented 2 years ago

I'll likely make some minor changes and PRs.