GrapheneOS / talkback

Apache License 2.0

11 stars 3 forks source link

Remove primes #3

Closed PatrykMis closed 2 years ago

PatrykMis commented 2 years ago

Originated from this patch

As stated here and in PrimesController.java, this is unnessesary performance metrics tied to Primes library. I also noticed additional improvement in TalkBack performance without Primes.

What is done:

removed unnessesary permissions
code cleanup from Primes and Primes references
May be some TalkBack performance improvements.

SkewedZeppelin commented 2 years ago

Alternatively, my original commit: https://github.com/Divested-Mobile/talkback/commit/74df73825d050641ccc2605d41874f7264c0f17c

The F-Droid patch is mine too.

I actually tried to reach out to you shortly after I made that, but you had deleted your post from the F-Droid forum.

PatrykMis commented 2 years ago

@SkewedZeppelin Excelent. I think it would be more fair to cherry-pick your commit instead of mine. Especially because it fulfills also #4.

Glad to see here original patch author. Thank you for your great work! We'll be in touch because I do not want to duplicate things that are already well done.

Thanks also for @thestinger for maintaining here Talkback repo in good and up-to-date state.

PatrykMis commented 2 years ago

4 fulfills this request already and it is properly originated from @SkewedZeppelin too.