search

GrapheneOS / talkback

Apache License 2.0
11 stars 3 forks source link

Bump dependencies and Gradle Wrapper, fix deprecations, small build optimization #38

Closed PatrykMis closed 2 years ago

PatrykMis commented 2 years ago

@Zanthed @thestinger something wrong with this PR?

ghost commented 2 years ago

Will test this in my own personal fork, though I'm fairly positive there will be a new Talkback code dump when Android 13 comes out.

PatrykMis commented 2 years ago

@Zanthed thanks. Is everything ok now? From my point of view and tests it is.

ghost commented 2 years ago

We need to wait until Android 13. Now is not the time to be merging new content really. Android 13 is less than 2 weeks away and the last thing we need are more possible issues during the Android 12.1 -> 13 port.

After Android 13 is out and finalised for us, we can come back to this. I am highly certain there will be a new Talkback code dump when Android 13 is out.

thestinger commented 2 years ago

Applied the Gradle update across all the GrapheneOS standalone apps and AttestationServer so that commit won't be needed.

thestinger commented 2 years ago

Also seems to need a rebase.

PatrykMis commented 2 years ago

Thanks @thestinger , done. Everything should be ok now.

PatrykMis commented 2 years ago

There is v13.0.0 on Play Store already. I've mentioned @simplexatg on one of pull requests, but updates are not pushed more often than approx. 6 months. Let's hope we see 13.0.0's source code sooner than later.

PatrykMis commented 2 years ago

Everything tested on few devices and working except top left back button in TalkBack's settings which is upstream bug (don't know how to fix it).

thestinger commented 2 years ago

@PatrykMis Can you rebase this?

PatrykMis commented 2 years ago

@thestinger yes of course, done.