GrapheneOS / talkback

Apache License 2.0
11 stars 3 forks source link

Update NDK in CI #74

Closed topminipie closed 6 months ago

topminipie commented 6 months ago

App used NDK 26.2.11394342 1 2

Android NDK

PatrykMis commented 6 months ago

NDK in CI is intentional. Look at the Compatibility section in AGP Release Notes.

If we raise NDK above 25.1.x, the libs won't be stripped, for example, thus the APK will be much larger. Also note that while building, Gradle uses version from Gradle scripts and AGP's default version for the rest of the stuff, like stripping. I have tested it thoroughly.

thestinger commented 6 months ago

We only use CI to test building though.

PatrykMis commented 6 months ago

@thestinger following this criteria, we should set JDK 21 instead of 17 in the CI, too.

thestinger commented 6 months ago

We do use JDK 21 in CI for our own apps despite using JDK 17 to build them.

thestinger commented 6 months ago

Done.