jdigne
commented
4 years ago No the deps were not given in the readme and the code does not run since there is no pretrained model nor available dataset, I could guess the deps from the train.py, but I'm not sure that it would be of significance for this project... There is a legal issue as far as I understand regarding the dataset they used
On 08/09/2020 15:51, David Coeurjolly wrote:
@dcoeurjo approved this pull request.
THanks, just a minor comment
In data/siggraph-2019/10.1145-3306346.3322941.json https://github.com/GraphicsReplicability/replicability.graphics/pull/170#discussion_r484935327:
+
- "Documentation score {0=NA,1,2,3}": 0,
- "Dependencies score {0=NA, 1,2,3,4,5}": 0,
- "Build/configure score {0=NA, 1,2,3,4,5}": 0,
- "Fixing bugs score (if any) {0=NA, 1,2,3,4,5}": 0,
- "Replicate paper results score {0=NA, 1,2,3,4,5}": 0,
- "Adaptability score to other contexts {0=NA, 1,2,3,4,5}": 0,
- "Time spent for the test (code download to first successful run, [0,10], 10min slots, 100min max)": 1,
- "Build instructions/comments": "Could not run due to missing data: the dataset is no longer available, and no pretrained model is given. The necessary packages are not listed in the readme file.",
have you listed the deps you've had to add ? (maybe hard to say as your system may already have some of them)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GraphicsReplicability/replicability.graphics/pull/170#pullrequestreview-484159287, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIYHIMAGPKR7FQ3ETMHBDDSEYZFFANCNFSM4Q77I5CQ.
-- Julie Digne Chargée de Recherche - CNRS LIRIS-Géomod, Université Claude Bernard Lyon 1 Bâtiment Nautibus Bureau 208 23-25 avenue Pierre de Coubertin 69622 Villeurbanne Cedex Tel : (+33) (0)4 72 43 26 62 Fax : (+33) (0)4 72 43 15 36 julie.digne@liris.cnrs.fr http://liris.cnrs.fr/julie.digne/
dcoeurjo
This Pull Request introduces changes to the following papers:
Thanks for contributing to this project. Contribution rules and help are available here: https://replicability.graphics/index.html#contribute.
Your contribution will be validated by project owners. Upon acceptance, it will appear automatically on the website https://replicability.graphics
Note about self-reviewing: we accept the reviews provided by the authors of a paper. These reviews will be clearly identified and may be double checked to validate the replicability. If you're an author, please clearly mention it when submitting your review (pull-request or email).