search

Graphite-Docs / graphite

Encrypted, secure, user-owned productivity suite
https://graphitedocs.com
GNU General Public License v3.0
583 stars 90 forks source link

Weird glitches. Hitting backspace after working on a document for a while causes page to jump #125

Closed CloverFeywilde closed 5 years ago

CloverFeywilde commented 5 years ago

I've tested this bug on a few different computers. After a while Graphite will jump to the bottom of the page any time the backspace key is hit, or if basically any of the toolbar options are clicked. I took a look at the console to see if it was throwing any errors, and all I found was this:

moreerros

I don't know if these errors are at all related to the bug, or a separate issue entirely.

polluterofminds commented 5 years ago

Those errors are unrelated to the problem you're seeing. Does the issue happen after a certain amount of text is input or does it happen always?

CloverFeywilde commented 5 years ago

I've looked into it a bit more and it appears to be after a certain amount of text. I tried deleting a paragraph and the behavior temporarily stopped. When I put the paragraph back in it started back up.

polluterofminds commented 5 years ago

This may very well be the underlying open source editor Graphite uses and customizes. I'm looking into it further. Here's one of the issues I found from that codebase that might be causing this: https://github.com/quilljs/quill/issues/2197

I'll continue exploring ways Graphite can mitigate this.

polluterofminds commented 5 years ago

Oh man, I just added a 50k word document to test this one and it's a nightmare. Good catch! If the underlying editor can't support that amount of text, Graphite's going to go with a different solution.

CloverFeywilde commented 5 years ago

I'm glad I could be of some help in pointing these things out. I want as much as I can to support the open internet and see to it that solid projects like this are integrated into my daily workflow.

It's a shame that Quill hasn't fixed that crippling problem with their software. It's seems like it's so well put together otherwise.

polluterofminds commented 5 years ago

Looks like Slate.js has some optimization for large documents.

https://www.slatejs.org/#/huge-document

I'll be exploring that. I really appreciate you banging on Graphite so much. It's good to catch some of the more common use cases as well as the edge cases.

polluterofminds commented 5 years ago

@bryanwillis7 the new editor is released! It should support these large documents much much better. Closing this issue now.