search

Graphite-Docs / graphite

Encrypted, secure, user-owned productivity suite
https://graphitedocs.com
GNU General Public License v3.0
586 stars 89 forks source link

Fixes compilation error related to prod.js file #68

Closed arisgk closed 5 years ago

arisgk commented 5 years ago

Fixes #67

polluterofminds commented 5 years ago

Thanks for the PR @arisgk! The problem I can see with this PR is that it would be very easy for me (or anyone I work with on the production app) to pull from the repo and overwrite the prod.js file used in production. That file, obviously, is not committed here because it contains keys. Those keys are just client ids and not secrets, so it wouldn't be devastating to have them in the repo (in fact, I think they were accidentally committed once). But in the event that I start storing secrets in this file as well, I don't want to commit it and I don't want it to be overwritten a pull.

I wonder if it's just easier to include the steps to create the prod.js file like you did in the readme?

arisgk commented 5 years ago

Right, I thought that because this prod.js file is gitignored pulling won't override the existing ones. But we can certainly add instructions to the Readme too, closing this PR.