Fix artboard deletion - Githubissues

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.

https://graphite.rs

Apache License 2.0

7.77k stars 408 forks source link

Fix artboard deletion #1651

Closed skoriop closed 6 months ago

skoriop commented 7 months ago

This PR ensures that:

[x] Document > Clear Artboards does not delete its children
[x] Artboard Tool > Delete does not delete its children

Closes #1505.

Keavon commented 7 months ago

!build

github-actions[bot] commented 7 months ago

📦 Build Complete for 3b4ee6dc67c5bfdb1de5482473e69b7dd635275f
https://64829471.graphite.pages.dev

Keavon commented 7 months ago

Nice work on the core functionality! Just one bug I notice if I draw several artboards, selecting one with the Artboard tool and deleting it causes the others to disappear (from getting disconnected in the graph). I think this is still the case in master so you didn't cause a regression, but since this is related to that bug I'd appreciate it if you'd help investigate and fix that here too. (Or feel free to say no, it can also be a followup PR.)

https://github.com/GraphiteEditor/Graphite/assets/4388688/253c6cad-b5c5-453c-a7d8-8c1a28e9b016

Keavon commented 6 months ago

!build

github-actions[bot] commented 6 months ago

📦 Build Complete for 7a9c5bd3800301d1fe4d45b1cd114876eb8ec477
https://3cd36118.graphite.pages.dev

Keavon commented 6 months ago

I'm marking this as draft for the moment, please mark it as ready for review again when you're ready, and also ping me so I notice it's ready again. Thanks.