Add auto-panning to the Artboard tool

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.

https://graphite.rs

Apache License 2.0

7.77k stars 408 forks source link

Add auto-panning to the Artboard tool #1652

Closed elbertronnie closed 6 months ago

elbertronnie commented 6 months ago

Partly closes #1527

Move all code related to auto-panning to auto_panning.rs.
Add auto-panning functionality to Artboard tool when in the state of ResizingBounds, Dragging or Drawing.
Hide debug messages containing AnimationFrame as specified in https://discord.com/channels/731730685944922173/881073965047636018/1214107184200421396

Keavon commented 6 months ago

Would it be reasonable to turn this PR into one which encompasses all the remaining tools, or do you think it requires too many changes and too much effort per tool that it'd be better to split it into one PR per tool?

elbertronnie commented 6 months ago

I stopped at one tool since I wanted confirmation on the way I have abstracted the code to auto_panning.rs. I was planning to merge 3-4 tools in a single PR once I have the confirmation.

I can combine it in one PR but it will take more than 2 weeks to complete it and diff size will definitely be above 500 lines. @Keavon So should I combine them in single PR?

Keavon commented 6 months ago

In that case, several PRs sounds preferable. Is this one ready for review and merging?

elbertronnie commented 6 months ago

Is this one ready for review and merging?

Yes

Keavon commented 6 months ago

!build

github-actions[bot] commented 6 months ago

📦 Build Complete for 88816aa640dc1db17a8849b12662ffef1b385aba
https://9459b48f.graphite.pages.dev