Don't save undo/redo history when aborting transactions

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.

https://graphite.rs

Apache License 2.0

7.31k stars 387 forks source link

Don't save undo/redo history when aborting transactions #1660

Closed milan-sedivy closed 3 months ago

milan-sedivy commented 3 months ago

For now solved with a simple split of undo/redo into a "forgettable" version and non-forgettable.
Fixes #1659

Keavon commented 3 months ago

!build

github-actions[bot] commented 3 months ago

📦 Build Complete for de2a2b03798127d23f2b94267f853952e12ce3e6
https://09f4ff5f.graphite.pages.dev

Keavon commented 3 months ago

Redo history is still wiped out (as before), but now it doesn't put the wrong history state into the redo history. E.g. previously, you could drag a shape upwards and abort, and that upward location where you aborted would be stored in one step of redo history. Now it simply loses all redo history, which is a separate issue.