Some tools send DocumentMessage::Undo instead of DocumentMessage::AbortTransaction when Aborting

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.

https://graphite.rs

Apache License 2.0

7.31k stars 387 forks source link

Some tools send DocumentMessage::Undo instead of DocumentMessage::AbortTransaction when Aborting #1663

Closed milan-sedivy closed 1 month ago

milan-sedivy commented 3 months ago

Example of a tool with this behavior is "SelectTool".

DocumentMessage::Undo stores the history step, which can lead to the deletion of a previously stored redo step see #1659 and related Pull request for more information.

Keavon commented 1 month ago

Was this resolved by #1664? If so, we can close this, but I'm not sure if that PR did indeed resolve it or if this issue's part was left unfinished.

Keavon commented 1 month ago

Presuming closed by #1664.